Changeset 183610 in webkit


Ignore:
Timestamp:
Apr 29, 2015 8:15:23 PM (9 years ago)
Author:
dino@apple.com
Message:

Create a named CSS property for system colors
https://bugs.webkit.org/show_bug.cgi?id=144423
<rdar://problem/20491011>

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/css/apple-system-colors.html

Expose the following values to CSS color properties:

-apple-system-blue
-apple-system-brown
-apple-system-gray
-apple-system-green
-apple-system-orange
-apple-system-pink
-apple-system-purple
-apple-system-red
-apple-system-yellow

On platforms other than OS X Yosemite and iOS, the
actual color values are undefined and become transparent
black. (In fact, not all are defined on iOS either.)

  • WebCore.xcodeproj/project.pbxproj: Two new SPI header files.
  • css/CSSParser.cpp:

(WebCore::CSSParser::validSystemColorValue): New helper function that
checks if a CSSValueID is between the two system color values. This
was being tested everywhere, which meant adding a new system color was
at risk of being ignored. It's a static method so it can be used
from the SVG CSS parser too.
(WebCore::validPrimitiveValueColor): Use the new helper.
(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseBackgroundColor): Ditto.
(WebCore::CSSParser::parseShadow): Ditto.
(WebCore::parseDeprecatedGradientColorStop): Ditto.
(WebCore::parseGradientColorOrKeyword): Ditto.

  • css/CSSParser.h: New static helper function.
  • css/CSSValueKeywords.in: Add the new CSS value keywords.
  • css/SVGCSSParser.cpp:

(WebCore::validSystemControlColorValue): SVG has a restricted
set of system colors, so use the helper from CSSParser but with
an extra condition.
(WebCore::CSSParser::parseSVGValue): Use the helper.

  • platform/spi/ios/UIColorSPI.h: Added.
  • platform/spi/cocoa/NSColorSPI.h: Added.
  • rendering/RenderThemeIOS.h: New systemColor override. Also add a cache for system colors.
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemColor): Ask UIColor to provide the color values for the new CSS values.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Ditto.

LayoutTests:

Expose the following values to CSS color properties:

-apple-system-blue
-apple-system-brown
-apple-system-gray
-apple-system-green
-apple-system-orange
-apple-system-pink
-apple-system-purple
-apple-system-red
-apple-system-yellow

The new test shows the computed value for each of these colors. It
includes generic results (no special value) and platform results for
Mac (other than Mavericks) and iOS.

  • fast/css/apple-system-colors-expected.txt: Generic results.
  • fast/css/apple-system-colors.html: Added - the new test.
  • platform/mac/fast/css/apple-system-colors-expected.txt: Added OS X results.
  • platform/ios-simulator/fast/css/apple-system-colors-expected.txt: Added iOS results.
  • platform/mac-mavericks/fast/css/apple-system-colors-expected.txt: Generic results for Mavericks.
Location:
trunk
Files:
7 added
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r183609 r183610  
     12015-04-29  Dean Jackson  <dino@apple.com>
     2
     3        Create a named CSS property for system colors
     4        https://bugs.webkit.org/show_bug.cgi?id=144423
     5        <rdar://problem/20491011>
     6
     7        Reviewed by Tim Horton.
     8
     9        Expose the following values to CSS color properties:
     10            -apple-system-blue
     11            -apple-system-brown
     12            -apple-system-gray
     13            -apple-system-green
     14            -apple-system-orange
     15            -apple-system-pink
     16            -apple-system-purple
     17            -apple-system-red
     18            -apple-system-yellow
     19
     20        The new test shows the computed value for each of these colors. It
     21        includes generic results (no special value) and platform results for
     22        Mac (other than Mavericks) and iOS.
     23
     24        * fast/css/apple-system-colors-expected.txt: Generic results.
     25        * fast/css/apple-system-colors.html: Added - the new test.
     26        * platform/mac/fast/css/apple-system-colors-expected.txt: Added OS X results.
     27        * platform/ios-simulator/fast/css/apple-system-colors-expected.txt: Added iOS results.
     28        * platform/mac-mavericks/fast/css/apple-system-colors-expected.txt: Generic results for Mavericks.
     29
    1302015-04-29  Commit Queue  <commit-queue@webkit.org>
    231
  • trunk/Source/WebCore/ChangeLog

    r183609 r183610  
     12015-04-29  Dean Jackson  <dino@apple.com>
     2
     3        Create a named CSS property for system colors
     4        https://bugs.webkit.org/show_bug.cgi?id=144423
     5        <rdar://problem/20491011>
     6
     7        Reviewed by Tim Horton.
     8
     9        Test: fast/css/apple-system-colors.html
     10
     11        Expose the following values to CSS color properties:
     12            -apple-system-blue
     13            -apple-system-brown
     14            -apple-system-gray
     15            -apple-system-green
     16            -apple-system-orange
     17            -apple-system-pink
     18            -apple-system-purple
     19            -apple-system-red
     20            -apple-system-yellow
     21
     22        On platforms other than OS X Yosemite and iOS, the
     23        actual color values are undefined and become transparent
     24        black. (In fact, not all are defined on iOS either.)
     25
     26        * WebCore.xcodeproj/project.pbxproj: Two new SPI header files.
     27
     28        * css/CSSParser.cpp:
     29        (WebCore::CSSParser::validSystemColorValue): New helper function that
     30        checks if a CSSValueID is between the two system color values. This
     31        was being tested everywhere, which meant adding a new system color was
     32        at risk of being ignored. It's a static method so it can be used
     33        from the SVG CSS parser too.
     34        (WebCore::validPrimitiveValueColor): Use the new helper.
     35        (WebCore::CSSParser::parseValue): Ditto.
     36        (WebCore::CSSParser::parseBackgroundColor): Ditto.
     37        (WebCore::CSSParser::parseShadow): Ditto.
     38        (WebCore::parseDeprecatedGradientColorStop): Ditto.
     39        (WebCore::parseGradientColorOrKeyword): Ditto.
     40        * css/CSSParser.h: New static helper function.
     41
     42        * css/CSSValueKeywords.in: Add the new CSS value keywords.
     43
     44        * css/SVGCSSParser.cpp:
     45        (WebCore::validSystemControlColorValue): SVG has a restricted
     46        set of system colors, so use the helper from CSSParser but with
     47        an extra condition.
     48        (WebCore::CSSParser::parseSVGValue): Use the helper.
     49
     50        * platform/spi/ios/UIColorSPI.h: Added.
     51        * platform/spi/cocoa/NSColorSPI.h: Added.
     52
     53        * rendering/RenderThemeIOS.h: New systemColor override. Also add a cache for system colors.
     54        * rendering/RenderThemeIOS.mm:
     55        (WebCore::RenderThemeIOS::systemColor): Ask UIColor to provide the color values for the new CSS values.
     56        * rendering/RenderThemeMac.mm:
     57        (WebCore::RenderThemeMac::systemColor): Ditto.
     58
    1592015-04-29  Commit Queue  <commit-queue@webkit.org>
    260
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r183598 r183610  
    13081308                31D591B316697A6C00E6BF02 /* PlugInClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 31D591B116697A6C00E6BF02 /* PlugInClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
    13091309                31DCD29D1AB4FBDE0072E817 /* AnimationTrigger.h in Headers */ = {isa = PBXBuildFile; fileRef = 31DCD29C1AB4FBDE0072E817 /* AnimationTrigger.h */; settings = {ATTRIBUTES = (Private, ); }; };
     1310                31DF63571AF187DD0078FD91 /* NSColorSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 31DF63561AF187DD0078FD91 /* NSColorSPI.h */; };
     1311                31DF63591AF194F00078FD91 /* UIColorSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 31DF63581AF194F00078FD91 /* UIColorSPI.h */; };
    13101312                31EAF97E121435A400E7C1BF /* DeviceMotionClientIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 31EAF97C121435A400E7C1BF /* DeviceMotionClientIOS.h */; };
    13111313                31EAF97F121435A400E7C1BF /* DeviceMotionClientIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 31EAF97D121435A400E7C1BF /* DeviceMotionClientIOS.mm */; };
     
    84488450                31D591B116697A6C00E6BF02 /* PlugInClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlugInClient.h; sourceTree = "<group>"; };
    84498451                31DCD29C1AB4FBDE0072E817 /* AnimationTrigger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AnimationTrigger.h; path = animation/AnimationTrigger.h; sourceTree = "<group>"; };
     8452                31DF63561AF187DD0078FD91 /* NSColorSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSColorSPI.h; sourceTree = "<group>"; };
     8453                31DF63581AF194F00078FD91 /* UIColorSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = UIColorSPI.h; path = ios/UIColorSPI.h; sourceTree = "<group>"; };
    84508454                31E8D8BA160BC94B004CE8F5 /* RenderSnapshottedPlugIn.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderSnapshottedPlugIn.cpp; sourceTree = "<group>"; };
    84518455                31E8D8BB160BC94C004CE8F5 /* RenderSnapshottedPlugIn.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderSnapshottedPlugIn.h; sourceTree = "<group>"; };
     
    1653516539                                A19D93441A9FEC7200B46C24 /* NEFilterSourceSPI.h */,
    1653616540                                CE1252501A1BEBD800864480 /* NSCalendarDateSPI.h */,
     16541                                31DF63561AF187DD0078FD91 /* NSColorSPI.h */,
    1653716542                                2DDB97F319F9AECA002025D8 /* NSExtensionSPI.h */,
    1653816543                                CE12523A1A16711000864480 /* NSFileManagerSPI.h */,
     
    1880918814                                6FAD4A561A9D0FAE009F7D3C /* OpenGLESSPI.h */,
    1881018815                                CE1252381A166FA000864480 /* QuickLookSPI.h */,
     18816                                31DF63581AF194F00078FD91 /* UIColorSPI.h */,
    1881118817                        );
    1881218818                        name = ios;
     
    2415624162                                4A0FFAA21AAF5EA20062803B /* RealtimeMediaSourceCenter.h in Headers */,
    2415724163                                4162A451101145AE00DFF3ED /* DedicatedWorkerGlobalScope.h in Headers */,
     24164                                31DF63571AF187DD0078FD91 /* NSColorSPI.h in Headers */,
    2415824165                                41A3D58F101C152D00316D07 /* DedicatedWorkerThread.h in Headers */,
    2415924166                                FD06DFA6134A4DEF006F5D7D /* DefaultAudioDestinationNode.h in Headers */,
     
    2658626593                                088A0E06126EF1DB00978F7A /* SVGAnimatedPropertyDescription.h in Headers */,
    2658726594                                088A0E07126EF1DB00978F7A /* SVGAnimatedPropertyMacros.h in Headers */,
     26595                                31DF63591AF194F00078FD91 /* UIColorSPI.h in Headers */,
    2658826596                                088A0E08126EF1DB00978F7A /* SVGAnimatedPropertyTearOff.h in Headers */,
    2658926597                                08C859C01274575400A5728D /* SVGAnimatedRect.h in Headers */,
  • trunk/Source/WebCore/css/CSSParser.cpp

    r183552 r183610  
    515515}
    516516
     517bool CSSParser::isValidSystemColorValue(CSSValueID valueID)
     518{
     519    return valueID >= CSSValueAqua && valueID <= CSSValueAppleSystemYellow;
     520}
     521
    517522static bool validPrimitiveValueColor(CSSValueID valueID, bool strict = false)
    518523{
    519524    return (valueID == CSSValueWebkitText || valueID == CSSValueCurrentcolor || valueID == CSSValueMenu
    520         || (valueID >= CSSValueAlpha && valueID <= CSSValueWindowtext)
     525        || CSSParser::isValidSystemColorValue(valueID) || valueID == CSSValueAlpha
    521526        || (valueID >= CSSValueWebkitFocusRingColor && valueID < CSSValueWebkitText && !strict));
    522527}
     
    20392044        else if (id == CSSValueCurrentcolor)
    20402045            validPrimitive = true;
    2041         else if ((id >= CSSValueAqua && id <= CSSValueWindowtext) || id == CSSValueMenu ||
    2042             (id >= CSSValueWebkitFocusRingColor && id < CSSValueWebkitText && inQuirksMode())) {
     2046        else if (isValidSystemColorValue(id) || id == CSSValueMenu
     2047            || (id >= CSSValueWebkitFocusRingColor && id < CSSValueWebkitText && inQuirksMode())) {
    20432048            validPrimitive = true;
    20442049        } else {
     
    28802885#if ENABLE(TOUCH_EVENTS)
    28812886    case CSSPropertyWebkitTapHighlightColor:
    2882         if ((id >= CSSValueAqua && id <= CSSValueWindowtext) || id == CSSValueMenu
     2887        if (isValidSystemColorValue(id) || id == CSSValueMenu
    28832888            || (id >= CSSValueWebkitFocusRingColor && id < CSSValueWebkitText && inQuirksMode())) {
    28842889            validPrimitive = true;
     
    41314136{
    41324137    CSSValueID id = m_valueList->current()->id;
    4133     if (id == CSSValueWebkitText || (id >= CSSValueAqua && id <= CSSValueWindowtext) || id == CSSValueMenu || id == CSSValueCurrentcolor ||
    4134         (id >= CSSValueGrey && id < CSSValueWebkitText && inQuirksMode()))
     4138    if (id == CSSValueWebkitText || isValidSystemColorValue(id) || id == CSSValueMenu || id == CSSValueCurrentcolor
     4139        || (id >= CSSValueGrey && id < CSSValueWebkitText && inQuirksMode()))
    41354140        return cssValuePool().createIdentifierValue(id);
    41364141    return parseColor();
     
    76257630            // The only other type of value that's ok is a color value.
    76267631            RefPtr<CSSPrimitiveValue> parsedColor;
    7627             bool isColor = ((value->id >= CSSValueAqua && value->id <= CSSValueWindowtext) || value->id == CSSValueMenu
     7632            bool isColor = (isValidSystemColorValue(value->id) || value->id == CSSValueMenu
    76287633                || (value->id >= CSSValueWebkitFocusRingColor && value->id <= CSSValueWebkitText && inQuirksMode())
    76297634                || value->id == CSSValueCurrentcolor);
     
    83868391
    83878392        CSSValueID id = args->current()->id;
    8388         if (id == CSSValueWebkitText || (id >= CSSValueAqua && id <= CSSValueWindowtext) || id == CSSValueMenu)
     8393        if (id == CSSValueWebkitText || CSSParser::isValidSystemColorValue(id) || id == CSSValueMenu)
    83898394            stop.m_color = cssValuePool().createIdentifierValue(id);
    83908395        else
     
    84138418        stopArg = args->next();
    84148419        CSSValueID id = stopArg->id;
    8415         if (id == CSSValueWebkitText || (id >= CSSValueAqua && id <= CSSValueWindowtext) || id == CSSValueMenu)
     8420        if (id == CSSValueWebkitText || CSSParser::isValidSystemColorValue(id) || id == CSSValueMenu)
    84168421            stop.m_color = cssValuePool().createIdentifierValue(id);
    84178422        else
     
    85848589{
    85858590    CSSValueID id = value.id;
    8586     if (id == CSSValueWebkitText || (id >= CSSValueAqua && id <= CSSValueWindowtext) || id == CSSValueMenu || id == CSSValueCurrentcolor)
     8591    if (id == CSSValueWebkitText || CSSParser::isValidSystemColorValue(id) || id == CSSValueMenu || id == CSSValueCurrentcolor)
    85878592        return cssValuePool().createIdentifierValue(id);
    85888593
  • trunk/Source/WebCore/css/CSSParser.h

    r183304 r183610  
    122122
    123123    static bool parseColor(RGBA32& color, const String&, bool strict = false);
     124    static bool isValidSystemColorValue(CSSValueID);
    124125    static bool parseSystemColor(RGBA32& color, const String&, Document*);
    125126    static PassRefPtr<CSSValueList> parseFontFaceValue(const AtomicString&);
  • trunk/Source/WebCore/css/CSSValueKeywords.in

    r183304 r183610  
    187187windowframe
    188188windowtext
     189-apple-system-blue
     190-apple-system-brown
     191-apple-system-gray
     192-apple-system-green
     193-apple-system-orange
     194-apple-system-pink
     195-apple-system-purple
     196-apple-system-red
     197-apple-system-yellow
    189198-webkit-focus-ring-color
    190199currentcolor
  • trunk/Source/WebCore/css/SVGCSSParser.cpp

    r177623 r183610  
    3333
    3434namespace WebCore {
     35
     36static bool isValidSystemControlColorValue(CSSValueID id)
     37{
     38    return id >= CSSValueActiveborder && CSSParser::isValidSystemColorValue(id);
     39}
    3540
    3641bool CSSParser::parseSVGValue(CSSPropertyID propId, bool important)
     
    188193            else if (id == CSSValueCurrentcolor)
    189194                parsedValue = SVGPaint::createCurrentColor();
    190             else if ((id >= CSSValueActiveborder && id <= CSSValueWindowtext) || id == CSSValueMenu)
     195            else if (isValidSystemControlColorValue(id) || id == CSSValueMenu)
    191196                parsedValue = SVGPaint::createColor(RenderTheme::defaultTheme()->systemColor(id));
    192197            else if (valueWithCalculation.value().unit == CSSPrimitiveValue::CSS_URI) {
     
    211216    case CSSPropertyFloodColor:
    212217    case CSSPropertyLightingColor:
    213         if ((id >= CSSValueAqua && id <= CSSValueWindowtext) ||
    214            (id >= CSSValueAliceblue && id <= CSSValueYellowgreen))
     218        if (CSSParser::isValidSystemColorValue(id)
     219            || (id >= CSSValueAliceblue && id <= CSSValueYellowgreen))
    215220            parsedValue = SVGColor::createFromString(valueWithCalculation.value().string);
    216221        else if (id == CSSValueCurrentcolor)
  • trunk/Source/WebCore/rendering/RenderThemeIOS.h

    r180490 r183610  
    112112#endif
    113113
     114    virtual Color systemColor(CSSValueID) const override;
     115
    114116private:
    115117    RenderThemeIOS();
     
    121123    String m_mediaControlsScript;
    122124    String m_mediaControlsStyleSheet;
     125
     126    mutable HashMap<int, RGBA32> m_systemColorCache;
    123127};
    124128
  • trunk/Source/WebCore/rendering/RenderThemeIOS.mm

    r183292 r183610  
    5757#import "RenderView.h"
    5858#import "SoftLinking.h"
     59#import "UIColorSPI.h"
    5960#import "UserAgentScripts.h"
    6061#import "UserAgentStyleSheets.h"
     
    6667#import <wtf/StdLibExtras.h>
    6768
     69SOFT_LINK_FRAMEWORK(UIKit)
     70SOFT_LINK_CLASS(UIKit, UIApplication)
     71SOFT_LINK_CLASS(UIKit, UIColor)
     72SOFT_LINK_CONSTANT(UIKit, UIContentSizeCategoryDidChangeNotification, CFStringRef)
     73#define UIContentSizeCategoryDidChangeNotification getUIContentSizeCategoryDidChangeNotification()
     74
     75#if !USE(APPLE_INTERNAL_SDK)
    6876@interface UIApplication
    6977+ (UIApplication *)sharedApplication;
    70 @property(nonatomic,copy) NSString *preferredContentSizeCategory;
     78@property (nonatomic, copy) NSString *preferredContentSizeCategory;
    7179@end
    72 
    73 SOFT_LINK_FRAMEWORK(UIKit)
    74 SOFT_LINK_CLASS(UIKit, UIApplication)
    75 SOFT_LINK_CONSTANT(UIKit, UIContentSizeCategoryDidChangeNotification, CFStringRef)
    76 #define UIContentSizeCategoryDidChangeNotification getUIContentSizeCategoryDidChangeNotification()
     80#endif
    7781
    7882@interface WebCoreRenderThemeBundle : NSObject
     
    13081312#endif // ENABLE(VIDEO)
    13091313
     1314Color RenderThemeIOS::systemColor(CSSValueID cssValueId) const
     1315{
     1316    {
     1317        auto it = m_systemColorCache.find(cssValueId);
     1318        if (it != m_systemColorCache.end())
     1319            return it->value;
     1320    }
     1321
     1322    Color color;
     1323    switch (cssValueId) {
     1324    case CSSValueAppleSystemBlue:
     1325        color = [getUIColorClass() systemBlueColor].CGColor;
     1326        break;
     1327    case CSSValueAppleSystemGray:
     1328        color = [getUIColorClass() systemGrayColor].CGColor;
     1329        break;
     1330    case CSSValueAppleSystemGreen:
     1331        color = [getUIColorClass() systemGreenColor].CGColor;
     1332        break;
     1333    case CSSValueAppleSystemOrange:
     1334        color = [getUIColorClass() systemOrangeColor].CGColor;
     1335        break;
     1336    case CSSValueAppleSystemPink:
     1337        color = [getUIColorClass() systemPinkColor].CGColor;
     1338        break;
     1339    case CSSValueAppleSystemRed:
     1340        color = [getUIColorClass() systemRedColor].CGColor;
     1341        break;
     1342    case CSSValueAppleSystemYellow:
     1343        color = [getUIColorClass() systemYellowColor].CGColor;
     1344        break;
     1345    default:
     1346        break;
     1347    }
     1348
     1349    if (!color.isValid())
     1350        color = RenderTheme::systemColor(cssValueId);
     1351
     1352    if (color.isValid())
     1353        m_systemColorCache.set(cssValueId, color.rgb());
     1354
     1355    return color;
     1356}
     1357
    13101358}
    13111359
  • trunk/Source/WebCore/rendering/RenderThemeMac.mm

    r183378 r183610  
    4949#import "LocalizedStrings.h"
    5050#import "MediaControlElements.h"
     51#import "NSColorSPI.h"
    5152#import "NSSharingServicePickerSPI.h"
    5253#import "Page.h"
     
    458459{
    459460    {
    460         HashMap<int, RGBA32>::iterator it = m_systemColorCache.find(cssValueId);
     461        auto it = m_systemColorCache.find(cssValueId);
    461462        if (it != m_systemColorCache.end())
    462463            return it->value;
     
    568569        color = convertNSColorToColor([NSColor windowFrameTextColor]);
    569570        break;
     571#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
     572    case CSSValueAppleSystemBlue:
     573        color = convertNSColorToColor([NSColor systemBlueColor]);
     574        break;
     575    case CSSValueAppleSystemBrown:
     576        color = convertNSColorToColor([NSColor systemBrownColor]);
     577        break;
     578    case CSSValueAppleSystemGray:
     579        color = convertNSColorToColor([NSColor systemGrayColor]);
     580        break;
     581    case CSSValueAppleSystemGreen:
     582        color = convertNSColorToColor([NSColor systemGreenColor]);
     583        break;
     584    case CSSValueAppleSystemOrange:
     585        color = convertNSColorToColor([NSColor systemOrangeColor]);
     586        break;
     587    case CSSValueAppleSystemPink:
     588        color = convertNSColorToColor([NSColor systemPinkColor]);
     589        break;
     590    case CSSValueAppleSystemPurple:
     591        color = convertNSColorToColor([NSColor systemPurpleColor]);
     592        break;
     593    case CSSValueAppleSystemRed:
     594        color = convertNSColorToColor([NSColor systemRedColor]);
     595        break;
     596    case CSSValueAppleSystemYellow:
     597        color = convertNSColorToColor([NSColor systemYellowColor]);
     598        break;
     599#endif
    570600    default:
    571601        break;
Note: See TracChangeset for help on using the changeset viewer.