Changeset 183680 in webkit


Ignore:
Timestamp:
May 1, 2015 10:50:49 AM (9 years ago)
Author:
Martin Robinson
Message:

[Freetype] Properly support synthetic oblique in vertical text
​https://bugs.webkit.org/show_bug.cgi?id=144492

Reviewed by Sergio Villar Senin.

Source/WebCore:

No new tests. Covered by existing tests.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::initializeWithFontFace): Skew vertical when using synthetic
oblique for vertical text.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip passing tests.
  • platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
  • platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r183676 r183680  
     12015-05-01  Martin Robinson  <mrobinson@igalia.com>
     2
     3        [Freetype] Properly support synthetic oblique in vertical text
     4        https://bugs.webkit.org/show_bug.cgi?id=144492
     5
     6        Reviewed by Sergio Villar Senin.
     7
     8        * platform/gtk/TestExpectations: Unskip passing tests.
     9        * platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
     10        * platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
     11
    1122015-05-01  Eric Carlson  <eric.carlson@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r183664 r183680  
    424424# No concept of secure text input
    425425Bug(GTK) editing/secure-input [ Failure ]
    426 
    427 # Synthesized italics not supported
    428 webkit.org/b/117975 fast/text/international/synthesized-italic-vertical-latin.html [ Skip ]
    429426
    430427# crypto.subtle is not yet enabled, but digest algorithms are already implemented
    … …  
    20062003webkit.org/b/118221 fast/text/complex-first-glyph-with-initial-advance.html [ ImageOnlyFailure ]
    20072004
    2008 webkit.org/b/118222 fast/text/international/synthesized-italic-vertical.html [ ImageOnlyFailure ]
    2009 
    20102005webkit.org/b/118416 storage/websql/sql-error-codes.html [ Failure ]
    20112006

  • trunk/Source/WebCore/ChangeLog

    r183678 r183680  
     12015-05-01  Martin Robinson  <mrobinson@igalia.com>
     2
     3        [Freetype] Properly support synthetic oblique in vertical text
     4        https://bugs.webkit.org/show_bug.cgi?id=144492
     5
     6        Reviewed by Sergio Villar Senin.
     7
     8        No new tests. Covered by existing tests.
     9
     10        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
     11        (WebCore::FontPlatformData::initializeWithFontFace): Skew vertical when using synthetic
     12        oblique for vertical text.
     13
    1142015-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
    215

  • trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp

    r183673 r183680  
    340340    if (syntheticOblique()) {
    341341        static const float syntheticObliqueSkew = -tanf(14 * acosf(0) / 90);
    342         cairo_matrix_t skew = {1, 0, syntheticObliqueSkew, 1, 0, 0};
    343         cairo_matrix_multiply(&fontMatrix, &skew, &fontMatrix);
     342        static const cairo_matrix_t skew = {1, 0, syntheticObliqueSkew, 1, 0, 0};
     343        static const cairo_matrix_t verticalSkew = {1, -syntheticObliqueSkew, 0, 1, 0, 0};
     344        cairo_matrix_multiply(&fontMatrix, m_orientation == Vertical ? &verticalSkew : &skew, &fontMatrix);
    344345    }
    345346
Note: See TracChangeset for help on using the changeset viewer.