Changeset 183714 in webkit

Timestamp:

May 2, 2015 2:41:26 AM (9 years ago)

Author:

timothy@apple.com

Message:

Web Inspector: Allow closing and reopening the Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=144513

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector._updateNewTabButtonState):

• UserInterface/Views/NewTabContentView.js:

(WebInspector.NewTabContentView):

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.closed):

• UserInterface/Views/ResourcesTabContentView.js:

(WebInspector.ResourcesTabContentView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (1 diff)
• UserInterface/Views/NewTabContentView.js (modified) (1 diff)
• UserInterface/Views/ResourceSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/ResourcesTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-05-02  Timothy Hatcher  <timothy@apple.com>
+
+        Web Inspector: Allow closing and reopening the Resources tab
+        https://bugs.webkit.org/show_bug.cgi?id=144513
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector._updateNewTabButtonState):
+        * UserInterface/Views/NewTabContentView.js:
+        (WebInspector.NewTabContentView):
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel):
+        (WebInspector.ResourceSidebarPanel.prototype.closed):
+        * UserInterface/Views/ResourcesTabContentView.js:
+        (WebInspector.ResourcesTabContentView):
+
 2015-05-02  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -432 +432 @@
 {
     var newTabAllowed = this.isNewTabWithTypeAllowed(WebInspector.ConsoleTabContentView.Type) || this.isNewTabWithTypeAllowed(WebInspector.ElementsTabContentView.Type)
-         || this.isNewTabWithTypeAllowed(WebInspector.StorageTabContentView.Type);
+         || this.isNewTabWithTypeAllowed(WebInspector.ResourcesTabContentView.Type) || this.isNewTabWithTypeAllowed(WebInspector.StorageTabContentView.Type);
     this.tabBar.newTabItem.disabled = !newTabAllowed;
 };

trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js

@@ -32 +32 @@
     var allowedNewTabs = [
         {image: "Images/Elements.svg", title: WebInspector.UIString("Elements"), type: WebInspector.ElementsTabContentView.Type},
+        {image: "Images/Resources.svg", title: WebInspector.UIString("Resources"), type: WebInspector.ResourcesTabContentView.Type},
         {image: "Images/Storage.svg", title: WebInspector.UIString("Storage"), type: WebInspector.StorageTabContentView.Type},
         {image: "Images/Console.svg", title: WebInspector.UIString("Console"), type: WebInspector.ConsoleTabContentView.Type}

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

@@ -48 +48 @@
         if (WebInspector.debuggableType === WebInspector.DebuggableType.JavaScript)
             this.contentTreeOutline.element.classList.add(WebInspector.NavigationSidebarPanel.HideDisclosureButtonsStyleClassName);
+
+        if (WebInspector.frameResourceManager.mainFrame)
+            this._mainFrameMainResourceDidChange(WebInspector.frameResourceManager.mainFrame);
     }
 
     // Public
+
+    closed()
+    {
+        WebInspector.Frame.removeEventListener(null, null, this);
+        WebInspector.frameResourceManager.removeEventListener(null, null, this);
+        WebInspector.debuggerManager.removeEventListener(null, null, this);
+        WebInspector.notifications.removeEventListener(null, null, this);
+    }
 
     showDefaultContentView()

trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js

@@ -34 +34 @@
         detailsSidebarPanels.push(WebInspector.layerTreeDetailsSidebarPanel);
 
-    // FIME: Until ResourceSidebarPanel supports instantiating after inspector launch, disable closing.
-    tabBarItem.hideCloseButton = true;
-
     WebInspector.ContentBrowserTabContentView.call(this, identifier || "resources", "resources", tabBarItem, WebInspector.ResourceSidebarPanel, detailsSidebarPanels);
 };