Changeset 183726 in webkit
- Timestamp:
- May 2, 2015 7:20:17 PM (9 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 36 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r183725 r183726 1 2015-05-02 Gyuyoung Kim <gyuyoung.kim@samsung.com> 2 3 Purge PassRefPtr create() factory functions in html 4 https://bugs.webkit.org/show_bug.cgi?id=144522 5 6 Reviewed by Darin Adler. 7 8 Return Ref instead of PassRefPtr in create() factory functions in html, because the factory 9 can't return null. This patch is a first step to purge in html. Following patch is going to 10 be uploaded. 11 12 No new tests, no behavior changes. 13 14 * html/FileInputType.cpp: 15 (WebCore::UploadButtonElement::create): 16 (WebCore::UploadButtonElement::createForMultiple): 17 * html/MediaController.cpp: 18 (MediaController::create): 19 * html/MediaController.h: 20 * html/canvas/WebGLBuffer.cpp: 21 (WebCore::WebGLBuffer::create): 22 * html/canvas/WebGLBuffer.h: 23 * html/canvas/WebGLContextAttributes.cpp: 24 (WebCore::WebGLContextAttributes::create): 25 * html/canvas/WebGLContextAttributes.h: 26 * html/canvas/WebGLContextGroup.cpp: 27 (WebCore::WebGLContextGroup::create): 28 * html/canvas/WebGLContextGroup.h: 29 * html/canvas/WebGLFramebuffer.cpp: 30 (WebCore::WebGLFramebuffer::create): 31 * html/canvas/WebGLFramebuffer.h: 32 * html/canvas/WebGLProgram.cpp: 33 (WebCore::WebGLProgram::create): 34 * html/canvas/WebGLProgram.h: 35 * html/canvas/WebGLQuery.cpp: 36 (WebCore::WebGLQuery::create): 37 * html/canvas/WebGLQuery.h: 38 * html/canvas/WebGLRenderbuffer.cpp: 39 (WebCore::WebGLRenderbuffer::create): 40 * html/canvas/WebGLRenderbuffer.h: 41 * html/canvas/WebGLSampler.cpp: 42 (WebCore::WebGLSampler::create): 43 * html/canvas/WebGLSampler.h: 44 * html/canvas/WebGLShader.cpp: 45 (WebCore::WebGLShader::create): 46 * html/canvas/WebGLShader.h: 47 * html/canvas/WebGLShaderPrecisionFormat.cpp: 48 (WebCore::WebGLShaderPrecisionFormat::create): 49 * html/canvas/WebGLShaderPrecisionFormat.h: 50 * html/canvas/WebGLSync.cpp: 51 (WebCore::WebGLSync::create): 52 * html/canvas/WebGLSync.h: 53 * html/canvas/WebGLTexture.cpp: 54 (WebCore::WebGLTexture::create): 55 * html/canvas/WebGLTexture.h: 56 * html/canvas/WebGLTransformFeedback.cpp: 57 (WebCore::WebGLTransformFeedback::create): 58 * html/canvas/WebGLTransformFeedback.h: 59 * html/canvas/WebGLUniformLocation.cpp: 60 (WebCore::WebGLUniformLocation::create): 61 * html/canvas/WebGLUniformLocation.h: 62 * html/canvas/WebGLVertexArrayObject.cpp: 63 (WebCore::WebGLVertexArrayObject::create): 64 * html/canvas/WebGLVertexArrayObject.h: 65 * html/canvas/WebGLVertexArrayObjectOES.cpp: 66 (WebCore::WebGLVertexArrayObjectOES::create): 67 * html/canvas/WebGLVertexArrayObjectOES.h: 68 1 69 2015-05-02 Andreas Kling <akling@apple.com> 2 70 -
trunk/Source/WebCore/html/FileInputType.cpp
r177259 r183726 48 48 class UploadButtonElement final : public HTMLInputElement { 49 49 public: 50 static PassRefPtr<UploadButtonElement> create(Document&);51 static PassRefPtr<UploadButtonElement> createForMultiple(Document&);50 static Ref<UploadButtonElement> create(Document&); 51 static Ref<UploadButtonElement> createForMultiple(Document&); 52 52 53 53 private: … … 55 55 }; 56 56 57 PassRefPtr<UploadButtonElement> UploadButtonElement::create(Document& document)58 { 59 Ref Ptr<UploadButtonElement> button = adoptRef(new UploadButtonElement(document));57 Ref<UploadButtonElement> UploadButtonElement::create(Document& document) 58 { 59 Ref<UploadButtonElement> button = adoptRef(*new UploadButtonElement(document)); 60 60 button->setValue(fileButtonChooseFileLabel()); 61 return button .release();62 } 63 64 PassRefPtr<UploadButtonElement> UploadButtonElement::createForMultiple(Document& document)65 { 66 Ref Ptr<UploadButtonElement> button = adoptRef(new UploadButtonElement(document));61 return button; 62 } 63 64 Ref<UploadButtonElement> UploadButtonElement::createForMultiple(Document& document) 65 { 66 Ref<UploadButtonElement> button = adoptRef(*new UploadButtonElement(document)); 67 67 button->setValue(fileButtonChooseMultipleFilesLabel()); 68 return button .release();68 return button; 69 69 } 70 70 -
trunk/Source/WebCore/html/MediaController.cpp
r176459 r183726 38 38 using namespace WebCore; 39 39 40 PassRefPtr<MediaController> MediaController::create(ScriptExecutionContext& context)41 { 42 return adoptRef( new MediaController(context));40 Ref<MediaController> MediaController::create(ScriptExecutionContext& context) 41 { 42 return adoptRef(*new MediaController(context)); 43 43 } 44 44 -
trunk/Source/WebCore/html/MediaController.h
r176459 r183726 46 46 class MediaController final : public RefCounted<MediaController>, public MediaControllerInterface, public EventTargetWithInlineData { 47 47 public: 48 static PassRefPtr<MediaController> create(ScriptExecutionContext&);48 static Ref<MediaController> create(ScriptExecutionContext&); 49 49 virtual ~MediaController(); 50 50 -
trunk/Source/WebCore/html/canvas/WebGLBuffer.cpp
r178674 r183726 35 35 namespace WebCore { 36 36 37 PassRefPtr<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx)38 { 39 return adoptRef( new WebGLBuffer(ctx));37 Ref<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx) 38 { 39 return adoptRef(*new WebGLBuffer(ctx)); 40 40 } 41 41 -
trunk/Source/WebCore/html/canvas/WebGLBuffer.h
r178674 r183726 42 42 virtual ~WebGLBuffer(); 43 43 44 static PassRefPtr<WebGLBuffer> create(WebGLRenderingContextBase*);44 static Ref<WebGLBuffer> create(WebGLRenderingContextBase*); 45 45 46 46 bool associateBufferData(GC3Dsizeiptr size); -
trunk/Source/WebCore/html/canvas/WebGLContextAttributes.cpp
r95901 r183726 33 33 namespace WebCore { 34 34 35 PassRefPtr<WebGLContextAttributes> WebGLContextAttributes::create()35 Ref<WebGLContextAttributes> WebGLContextAttributes::create() 36 36 { 37 return adoptRef( new WebGLContextAttributes());37 return adoptRef(*new WebGLContextAttributes()); 38 38 } 39 39 40 PassRefPtr<WebGLContextAttributes> WebGLContextAttributes::create(GraphicsContext3D::Attributes attributes)40 Ref<WebGLContextAttributes> WebGLContextAttributes::create(GraphicsContext3D::Attributes attributes) 41 41 { 42 return adoptRef( new WebGLContextAttributes(attributes));42 return adoptRef(*new WebGLContextAttributes(attributes)); 43 43 } 44 44 -
trunk/Source/WebCore/html/canvas/WebGLContextAttributes.h
r175328 r183726 39 39 40 40 // Create a new attributes object 41 static PassRefPtr<WebGLContextAttributes> create();41 static Ref<WebGLContextAttributes> create(); 42 42 43 43 // Create a new attributes object initialized with preexisting attributes 44 static PassRefPtr<WebGLContextAttributes> create(GraphicsContext3D::Attributes attributes);44 static Ref<WebGLContextAttributes> create(GraphicsContext3D::Attributes); 45 45 46 46 // Whether or not the drawing buffer has an alpha channel; default=true -
trunk/Source/WebCore/html/canvas/WebGLContextGroup.cpp
r178674 r183726 36 36 namespace WebCore { 37 37 38 PassRefPtr<WebGLContextGroup> WebGLContextGroup::create()38 Ref<WebGLContextGroup> WebGLContextGroup::create() 39 39 { 40 RefPtr<WebGLContextGroup> contextGroup = adoptRef(new WebGLContextGroup()); 41 return contextGroup.release(); 40 return adoptRef(*new WebGLContextGroup()); 42 41 } 43 42 -
trunk/Source/WebCore/html/canvas/WebGLContextGroup.h
r178674 r183726 43 43 class WebGLContextGroup final : public RefCounted<WebGLContextGroup> { 44 44 public: 45 static PassRefPtr<WebGLContextGroup> create();45 static Ref<WebGLContextGroup> create(); 46 46 ~WebGLContextGroup(); 47 47 -
trunk/Source/WebCore/html/canvas/WebGLFramebuffer.cpp
r181573 r183726 46 46 class WebGLRenderbufferAttachment : public WebGLFramebuffer::WebGLAttachment { 47 47 public: 48 static PassRefPtr<WebGLFramebuffer::WebGLAttachment> create(WebGLRenderbuffer*);48 static Ref<WebGLFramebuffer::WebGLAttachment> create(WebGLRenderbuffer*); 49 49 50 50 private: … … 67 67 }; 68 68 69 PassRefPtr<WebGLFramebuffer::WebGLAttachment> WebGLRenderbufferAttachment::create(WebGLRenderbuffer* renderbuffer)70 { 71 return adoptRef( new WebGLRenderbufferAttachment(renderbuffer));69 Ref<WebGLFramebuffer::WebGLAttachment> WebGLRenderbufferAttachment::create(WebGLRenderbuffer* renderbuffer) 70 { 71 return adoptRef(*new WebGLRenderbufferAttachment(renderbuffer)); 72 72 } 73 73 … … 140 140 class WebGLTextureAttachment : public WebGLFramebuffer::WebGLAttachment { 141 141 public: 142 static PassRefPtr<WebGLFramebuffer::WebGLAttachment> create(WebGLTexture*, GC3Denum target, GC3Dint level);142 static Ref<WebGLFramebuffer::WebGLAttachment> create(WebGLTexture*, GC3Denum target, GC3Dint level); 143 143 144 144 private: … … 163 163 }; 164 164 165 PassRefPtr<WebGLFramebuffer::WebGLAttachment> WebGLTextureAttachment::create(WebGLTexture* texture, GC3Denum target, GC3Dint level)166 { 167 return adoptRef( new WebGLTextureAttachment(texture, target, level));165 Ref<WebGLFramebuffer::WebGLAttachment> WebGLTextureAttachment::create(WebGLTexture* texture, GC3Denum target, GC3Dint level) 166 { 167 return adoptRef(*new WebGLTextureAttachment(texture, target, level)); 168 168 } 169 169 … … 270 270 } 271 271 272 PassRefPtr<WebGLFramebuffer> WebGLFramebuffer::create(WebGLRenderingContextBase* ctx)273 { 274 return adoptRef( new WebGLFramebuffer(ctx));272 Ref<WebGLFramebuffer> WebGLFramebuffer::create(WebGLRenderingContextBase* ctx) 273 { 274 return adoptRef(*new WebGLFramebuffer(ctx)); 275 275 } 276 276 -
trunk/Source/WebCore/html/canvas/WebGLFramebuffer.h
r178674 r183726 62 62 virtual ~WebGLFramebuffer(); 63 63 64 static PassRefPtr<WebGLFramebuffer> create(WebGLRenderingContextBase*);64 static Ref<WebGLFramebuffer> create(WebGLRenderingContextBase*); 65 65 66 66 void setAttachmentForBoundFramebuffer(GC3Denum attachment, GC3Denum texTarget, WebGLTexture*, GC3Dint level); -
trunk/Source/WebCore/html/canvas/WebGLProgram.cpp
r178674 r183726 35 35 namespace WebCore { 36 36 37 PassRefPtr<WebGLProgram> WebGLProgram::create(WebGLRenderingContextBase* ctx)37 Ref<WebGLProgram> WebGLProgram::create(WebGLRenderingContextBase* ctx) 38 38 { 39 return adoptRef( new WebGLProgram(ctx));39 return adoptRef(*new WebGLProgram(ctx)); 40 40 } 41 41 -
trunk/Source/WebCore/html/canvas/WebGLProgram.h
r178674 r183726 40 40 virtual ~WebGLProgram(); 41 41 42 static PassRefPtr<WebGLProgram> create(WebGLRenderingContextBase*);42 static Ref<WebGLProgram> create(WebGLRenderingContextBase*); 43 43 44 44 unsigned numActiveAttribLocations(); -
trunk/Source/WebCore/html/canvas/WebGLQuery.cpp
r178963 r183726 34 34 namespace WebCore { 35 35 36 PassRefPtr<WebGLQuery> WebGLQuery::create(WebGLRenderingContextBase* ctx)36 Ref<WebGLQuery> WebGLQuery::create(WebGLRenderingContextBase* ctx) 37 37 { 38 return adoptRef( new WebGLQuery(ctx));38 return adoptRef(*new WebGLQuery(ctx)); 39 39 } 40 40 -
trunk/Source/WebCore/html/canvas/WebGLQuery.h
r178963 r183726 38 38 virtual ~WebGLQuery(); 39 39 40 static PassRefPtr<WebGLQuery> create(WebGLRenderingContextBase*);40 static Ref<WebGLQuery> create(WebGLRenderingContextBase*); 41 41 42 42 protected: -
trunk/Source/WebCore/html/canvas/WebGLRenderbuffer.cpp
r178674 r183726 35 35 namespace WebCore { 36 36 37 PassRefPtr<WebGLRenderbuffer> WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx)37 Ref<WebGLRenderbuffer> WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx) 38 38 { 39 return adoptRef( new WebGLRenderbuffer(ctx));39 return adoptRef(*new WebGLRenderbuffer(ctx)); 40 40 } 41 41 -
trunk/Source/WebCore/html/canvas/WebGLRenderbuffer.h
r178674 r183726 38 38 virtual ~WebGLRenderbuffer(); 39 39 40 static PassRefPtr<WebGLRenderbuffer> create(WebGLRenderingContextBase*);40 static Ref<WebGLRenderbuffer> create(WebGLRenderingContextBase*); 41 41 42 42 void setInternalFormat(GC3Denum internalformat) -
trunk/Source/WebCore/html/canvas/WebGLSampler.cpp
r178963 r183726 34 34 namespace WebCore { 35 35 36 PassRefPtr<WebGLSampler> WebGLSampler::create(WebGLRenderingContextBase* ctx)36 Ref<WebGLSampler> WebGLSampler::create(WebGLRenderingContextBase* ctx) 37 37 { 38 return adoptRef( new WebGLSampler(ctx));38 return adoptRef(*new WebGLSampler(ctx)); 39 39 } 40 40 -
trunk/Source/WebCore/html/canvas/WebGLSampler.h
r178963 r183726 38 38 virtual ~WebGLSampler(); 39 39 40 static PassRefPtr<WebGLSampler> create(WebGLRenderingContextBase*);40 static Ref<WebGLSampler> create(WebGLRenderingContextBase*); 41 41 42 42 protected: -
trunk/Source/WebCore/html/canvas/WebGLShader.cpp
r178674 r183726 35 35 namespace WebCore { 36 36 37 PassRefPtr<WebGLShader> WebGLShader::create(WebGLRenderingContextBase* ctx, GC3Denum type)37 Ref<WebGLShader> WebGLShader::create(WebGLRenderingContextBase* ctx, GC3Denum type) 38 38 { 39 return adoptRef( new WebGLShader(ctx, type));39 return adoptRef(*new WebGLShader(ctx, type)); 40 40 } 41 41 -
trunk/Source/WebCore/html/canvas/WebGLShader.h
r178674 r183726 37 37 virtual ~WebGLShader(); 38 38 39 static PassRefPtr<WebGLShader> create(WebGLRenderingContextBase*, GC3Denum);39 static Ref<WebGLShader> create(WebGLRenderingContextBase*, GC3Denum); 40 40 41 41 GC3Denum getType() const { return m_type; } -
trunk/Source/WebCore/html/canvas/WebGLShaderPrecisionFormat.cpp
r113092 r183726 34 34 35 35 // static 36 PassRefPtr<WebGLShaderPrecisionFormat> WebGLShaderPrecisionFormat::create(GC3Dint rangeMin, GC3Dint rangeMax, GC3Dint precision)36 Ref<WebGLShaderPrecisionFormat> WebGLShaderPrecisionFormat::create(GC3Dint rangeMin, GC3Dint rangeMax, GC3Dint precision) 37 37 { 38 return adoptRef( new WebGLShaderPrecisionFormat(rangeMin, rangeMax, precision));38 return adoptRef(*new WebGLShaderPrecisionFormat(rangeMin, rangeMax, precision)); 39 39 } 40 40 -
trunk/Source/WebCore/html/canvas/WebGLShaderPrecisionFormat.h
r113092 r183726 36 36 class WebGLShaderPrecisionFormat : public RefCounted<WebGLShaderPrecisionFormat> { 37 37 public: 38 static PassRefPtr<WebGLShaderPrecisionFormat> create(GC3Dint rangeMin, GC3Dint rangeMax, GC3Dint precision);38 static Ref<WebGLShaderPrecisionFormat> create(GC3Dint rangeMin, GC3Dint rangeMax, GC3Dint precision); 39 39 40 40 GC3Dint rangeMin() const; -
trunk/Source/WebCore/html/canvas/WebGLSync.cpp
r178963 r183726 34 34 namespace WebCore { 35 35 36 PassRefPtr<WebGLSync> WebGLSync::create(WebGLRenderingContextBase* ctx)36 Ref<WebGLSync> WebGLSync::create(WebGLRenderingContextBase* ctx) 37 37 { 38 return adoptRef( new WebGLSync(ctx));38 return adoptRef(*new WebGLSync(ctx)); 39 39 } 40 40 -
trunk/Source/WebCore/html/canvas/WebGLSync.h
r178963 r183726 38 38 virtual ~WebGLSync(); 39 39 40 static PassRefPtr<WebGLSync> create(WebGLRenderingContextBase*);40 static Ref<WebGLSync> create(WebGLRenderingContextBase*); 41 41 42 42 protected: -
trunk/Source/WebCore/html/canvas/WebGLTexture.cpp
r178674 r183726 36 36 namespace WebCore { 37 37 38 PassRefPtr<WebGLTexture> WebGLTexture::create(WebGLRenderingContextBase* ctx)39 { 40 return adoptRef( new WebGLTexture(ctx));38 Ref<WebGLTexture> WebGLTexture::create(WebGLRenderingContextBase* ctx) 39 { 40 return adoptRef(*new WebGLTexture(ctx)); 41 41 } 42 42 -
trunk/Source/WebCore/html/canvas/WebGLTexture.h
r178674 r183726 45 45 virtual ~WebGLTexture(); 46 46 47 static PassRefPtr<WebGLTexture> create(WebGLRenderingContextBase*);47 static Ref<WebGLTexture> create(WebGLRenderingContextBase*); 48 48 49 49 void setTarget(GC3Denum target, GC3Dint maxLevel); -
trunk/Source/WebCore/html/canvas/WebGLTransformFeedback.cpp
r178963 r183726 34 34 namespace WebCore { 35 35 36 PassRefPtr<WebGLTransformFeedback> WebGLTransformFeedback::create(WebGLRenderingContextBase* ctx)36 Ref<WebGLTransformFeedback> WebGLTransformFeedback::create(WebGLRenderingContextBase* ctx) 37 37 { 38 return adoptRef( new WebGLTransformFeedback(ctx));38 return adoptRef(*new WebGLTransformFeedback(ctx)); 39 39 } 40 40 -
trunk/Source/WebCore/html/canvas/WebGLTransformFeedback.h
r178963 r183726 38 38 virtual ~WebGLTransformFeedback(); 39 39 40 static PassRefPtr<WebGLTransformFeedback> create(WebGLRenderingContextBase*);40 static Ref<WebGLTransformFeedback> create(WebGLRenderingContextBase*); 41 41 42 42 protected: -
trunk/Source/WebCore/html/canvas/WebGLUniformLocation.cpp
r165676 r183726 33 33 namespace WebCore { 34 34 35 PassRefPtr<WebGLUniformLocation> WebGLUniformLocation::create(WebGLProgram* program, GC3Dint location, GC3Denum type)35 Ref<WebGLUniformLocation> WebGLUniformLocation::create(WebGLProgram* program, GC3Dint location, GC3Denum type) 36 36 { 37 return adoptRef( new WebGLUniformLocation(program, location, type));37 return adoptRef(*new WebGLUniformLocation(program, location, type)); 38 38 } 39 39 -
trunk/Source/WebCore/html/canvas/WebGLUniformLocation.h
r175149 r183726 39 39 ~WebGLUniformLocation() { } 40 40 41 static PassRefPtr<WebGLUniformLocation> create(WebGLProgram*, GC3Dint location, GC3Denum type);41 static Ref<WebGLUniformLocation> create(WebGLProgram*, GC3Dint location, GC3Denum type); 42 42 43 43 WebGLProgram* program() const; -
trunk/Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
r181571 r183726 34 34 namespace WebCore { 35 35 36 PassRefPtr<WebGLVertexArrayObject> WebGLVertexArrayObject::create(WebGLRenderingContextBase* ctx, VAOType type)36 Ref<WebGLVertexArrayObject> WebGLVertexArrayObject::create(WebGLRenderingContextBase* ctx, VAOType type) 37 37 { 38 return adoptRef( new WebGLVertexArrayObject(ctx, type));38 return adoptRef(*new WebGLVertexArrayObject(ctx, type)); 39 39 } 40 40 -
trunk/Source/WebCore/html/canvas/WebGLVertexArrayObject.h
r181571 r183726 40 40 class WebGLVertexArrayObject final : public WebGLVertexArrayObjectBase { 41 41 public: 42 static PassRefPtr<WebGLVertexArrayObject> create(WebGLRenderingContextBase*, VAOType);42 static Ref<WebGLVertexArrayObject> create(WebGLRenderingContextBase*, VAOType); 43 43 virtual ~WebGLVertexArrayObject(); 44 44 private: -
trunk/Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.cpp
r181571 r183726 35 35 namespace WebCore { 36 36 37 PassRefPtr<WebGLVertexArrayObjectOES> WebGLVertexArrayObjectOES::create(WebGLRenderingContextBase* ctx, VAOType type)37 Ref<WebGLVertexArrayObjectOES> WebGLVertexArrayObjectOES::create(WebGLRenderingContextBase* ctx, VAOType type) 38 38 { 39 return adoptRef( new WebGLVertexArrayObjectOES(ctx, type));39 return adoptRef(*new WebGLVertexArrayObjectOES(ctx, type)); 40 40 } 41 41 -
trunk/Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h
r181571 r183726 37 37 class WebGLVertexArrayObjectOES final : public WebGLVertexArrayObjectBase { 38 38 public: 39 static PassRefPtr<WebGLVertexArrayObjectOES> create(WebGLRenderingContextBase*, VAOType);39 static Ref<WebGLVertexArrayObjectOES> create(WebGLRenderingContextBase*, VAOType); 40 40 virtual ~WebGLVertexArrayObjectOES(); 41 41 private:
Note: See TracChangeset
for help on using the changeset viewer.