Changeset 183740 in webkit

Timestamp:

May 4, 2015 1:42:28 AM (9 years ago)

Author:

Csaba Osztrogonác

Message:

[ARM] Don't compare unsigned chars to EOF (-1)
​https://bugs.webkit.org/show_bug.cgi?id=144439

Reviewed by Geoffrey Garen.

Source/WebCore:

• platform/linux/MemoryPressureHandlerLinux.cpp:

(WebKit::nextToken): Don't cast return value of fgetc() to char.

Source/WebKit2:

• Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::nextToken): Don't cast return value of fgetc() to char.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/linux/MemoryPressureHandlerLinux.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/linux/WebMemorySamplerLinux.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
+
+        [ARM] Don't compare unsigned chars to EOF (-1)
+        https://bugs.webkit.org/show_bug.cgi?id=144439
+
+        Reviewed by Geoffrey Garen.
+
+        * platform/linux/MemoryPressureHandlerLinux.cpp:
+        (WebKit::nextToken): Don't cast return value of fgetc() to char.
+
 2015-05-04  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp

@@ -66 +66 @@
     unsigned index = 0;
     while (index < bufferSize) {
-        char ch = fgetc(file);
+        int ch = fgetc(file);
         if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space.
             break;

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
+
+        [ARM] Don't compare unsigned chars to EOF (-1)
+        https://bugs.webkit.org/show_bug.cgi?id=144439
+
+        Reviewed by Geoffrey Garen.
+
+        * Shared/linux/WebMemorySamplerLinux.cpp:
+        (WebKit::nextToken): Don't cast return value of fgetc() to char.
+
 2015-05-04  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp

@@ -67 +67 @@
     unsigned int index = 0;
     while (index < maxBuffer) {
-        char ch = fgetc(file);
+        int ch = fgetc(file);
         if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space.
             break;