Changeset 183796 in webkit


Ignore:
Timestamp:
May 4, 2015 10:22:52 PM (9 years ago)
Author:
Brent Fulgham
Message:

Correct '--show-webview' option for Tiled Drawing tests
https://bugs.webkit.org/show_bug.cgi?id=144621

Reviewed by Simon Fraser.

The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
sure that the state of the '--show-webview' option was propagated to this additional view creation routine.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r183787 r183796  
     12015-05-04  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Correct '--show-webview' option for Tiled Drawing tests
     4        https://bugs.webkit.org/show_bug.cgi?id=144621
     5
     6        Reviewed by Simon Fraser.
     7
     8        The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
     9        sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
     10
     11        * WebKitTestRunner/mac/TestControllerMac.mm:
     12        (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
     13        WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
     14
    1152015-05-04  Filip Pizlo  <fpizlo@apple.com>
    216
  • trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm

    r183562 r183796  
    107107    auto useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));
    108108    WKDictionarySetItem(viewOptions.get(), useRemoteLayerTreeKey.get(), useRemoteLayerTreeValue.get());
     109
     110    auto shouldShowWebViewKey = adoptWK(WKStringCreateWithUTF8CString("ShouldShowWebView"));
     111    auto shouldShowWebViewValue = adoptWK(WKBooleanCreate(shouldShowWebView()));
     112    WKDictionarySetItem(viewOptions.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get());
    109113
    110114    ensureViewSupportsOptions(viewOptions.get());
Note: See TracChangeset for help on using the changeset viewer.