Changeset 183883 in webkit


Ignore:
Timestamp:
May 6, 2015 1:32:42 PM (9 years ago)
Author:
mmaxfield@apple.com
Message:

Introducing the Platform Abstraction Layer (PAL)
​https://bugs.webkit.org/show_bug.cgi?id=143358

Reviewed by Simon Fraser.

.:

  • WebKit.xcworkspace/contents.xcworkspacedata: Add it to the workspace.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Updated

Source/PAL:

Introduce a new top-level folder and static library. This is intended to be
the destination for code that currently resides in WebCore/platform. Code
will be moved from that folder into PAL file by file. Separating this
platform code into its own static library enforces layering, as well as
encourages/aids unit testing of this platform code.

This commit only creates a single symbol which is not required to build
WebKit. The reason for this is so that we can get all build issues ironed
out before requiring PAL.

For more information, see
​https://lists.webkit.org/pipermail/webkit-dev/2015-March/027303.html

  • PAL.xcodeproj/project.pbxproj: Added.
  • Makefile: Added. Standard Makefile.
  • config.h: Added. Standard header.
  • PALPrefix.h: Added. Copied from WebCore.
  • graphics/Foo.h: Added. Header.
  • graphics/Foo.cpp: Added.

(foo): Placeholder symbol.

  • Configurations/Base.xcconfig: Added. Standard config files
  • Configurations/DebugRelease.xcconfig: Added. Standard config files
  • Configurations/PAL.xcconfig: Added. Standard config files

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Let the project know about the .a
  • Configurations/FeatureDefines.xcconfig: Updated

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Updated

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Updated

Tools:

  • Scripts/build-webkit: Add it to build-webkit.
Location:
trunk
Files:
14 added
13 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r183741 r183883  
     12015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Introducing the Platform Abstraction Layer (PAL)
     4        https://bugs.webkit.org/show_bug.cgi?id=143358
     5
     6        Reviewed by Simon Fraser.
     7
     8        * WebKit.xcworkspace/contents.xcworkspacedata: Add it to the workspace.
     9
    1102015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
    211

  • trunk/Source/JavaScriptCore/ChangeLog

    r183874 r183883  
     12015-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Introducing the Platform Abstraction Layer (PAL)
     4        https://bugs.webkit.org/show_bug.cgi?id=143358
     5
     6        Reviewed by Simon Fraser.
     7
     8        * Configurations/FeatureDefines.xcconfig: Updated
     9
    1102015-05-06  Andreas Kling  <akling@apple.com>
    211

  • trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r183516 r183883  
    2424
    2525// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
    26 // WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
     26// PAL, WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
    2727// build-webkit should match the values below, but they do not need to be in the same order.
    2828

  • trunk/Source/PAL/Configurations/FeatureDefines.xcconfig

    r183882 r183883  
    2424
    2525// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
    26 // WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
     26// PAL, WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
    2727// build-webkit should match the values below, but they do not need to be in the same order.
    2828

  • trunk/Source/WebCore/ChangeLog

    r183881 r183883  
     12015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Introducing the Platform Abstraction Layer (PAL)
     4        https://bugs.webkit.org/show_bug.cgi?id=143358
     5
     6        Reviewed by Simon Fraser.
     7
     8        * WebCore.xcodeproj/project.pbxproj: Let the project know about the .a
     9        * Configurations/FeatureDefines.xcconfig: Updated
     10
    1112015-05-06  Eric Carlson  <eric.carlson@apple.com>
    212

  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r183516 r183883  
    2424
    2525// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
    26 // WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
     26// PAL, WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
    2727// build-webkit should match the values below, but they do not need to be in the same order.
    2828

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r183877 r183883  
    56275627                C105DA620F3AA68F001DD44F /* TextEncodingDetectorICU.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C105DA610F3AA68F001DD44F /* TextEncodingDetectorICU.cpp */; };
    56285628                C105DA640F3AA6B8001DD44F /* TextEncodingDetector.h in Headers */ = {isa = PBXBuildFile; fileRef = C105DA630F3AA6B8001DD44F /* TextEncodingDetector.h */; };
     5629                C214D9F51ACE35B4001C80BA /* libPAL.a in Frameworks */ = {isa = PBXBuildFile; fileRef = C214D9F41ACE35B4001C80BA /* libPAL.a */; };
    56295630                C330A22313EC196B0000B45B /* ColorChooser.h in Headers */ = {isa = PBXBuildFile; fileRef = C330A22113EC196B0000B45B /* ColorChooser.h */; settings = {ATTRIBUTES = (Private, ); }; };
    56305631                C33EE5C414FB49610002095A /* BaseClickableWithKeyInputType.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C33EE5C214FB49610002095A /* BaseClickableWithKeyInputType.cpp */; };
    … …  
    1316813169                C105DA610F3AA68F001DD44F /* TextEncodingDetectorICU.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextEncodingDetectorICU.cpp; sourceTree = "<group>"; };
    1316913170                C105DA630F3AA6B8001DD44F /* TextEncodingDetector.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextEncodingDetector.h; sourceTree = "<group>"; };
     13171                C214D9F41ACE35B4001C80BA /* libPAL.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libPAL.a; sourceTree = BUILT_PRODUCTS_DIR; };
    1317013172                C24685131A148E1800811792 /* CoreGraphicsSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CoreGraphicsSPI.h; path = cg/CoreGraphicsSPI.h; sourceTree = "<group>"; };
    1317113173                C2C4CB1D161A131200D214DA /* WebSafeIncrementalSweeperIOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WebSafeIncrementalSweeperIOS.h; path = ios/WebSafeIncrementalSweeperIOS.h; sourceTree = "<group>"; };
    … …  
    1495514957                        isa = PBXGroup;
    1495614958                        children = (
     14959                                C214D9F41ACE35B4001C80BA /* libPAL.a */,
    1495714960                                FD2DBF0E12B048A300ED98C6 /* Accelerate.framework */,
    1495814961                                FD2DBF0F12B048A300ED98C6 /* AudioToolbox.framework */,

  • trunk/Source/WebKit/mac/ChangeLog

    r183875 r183883  
     12015-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Introducing the Platform Abstraction Layer (PAL)
     4        https://bugs.webkit.org/show_bug.cgi?id=143358
     5
     6        Reviewed by Simon Fraser.
     7
     8        * Configurations/FeatureDefines.xcconfig: Updated
     9
    1102015-05-06  Antti Koivisto  <antti@apple.com>
    211

  • trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig

    r183516 r183883  
    2424
    2525// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
    26 // WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
     26// PAL, WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
    2727// build-webkit should match the values below, but they do not need to be in the same order.
    2828

  • trunk/Source/WebKit2/ChangeLog

    r183865 r183883  
     12015-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Introducing the Platform Abstraction Layer (PAL)
     4        https://bugs.webkit.org/show_bug.cgi?id=143358
     5
     6        Reviewed by Simon Fraser.
     7
     8        * Configurations/FeatureDefines.xcconfig: Updated
     9
    1102015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
    211

  • trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig

    r183516 r183883  
    2424
    2525// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
    26 // WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
     26// PAL, WebCore, WebKit and WebKit2.  Also the default values of the ENABLE_FEATURE_NAME macros in
    2727// build-webkit should match the values below, but they do not need to be in the same order.
    2828

  • trunk/Tools/ChangeLog

    r183882 r183883  
     12015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Introducing the Platform Abstraction Layer (PAL)
     4        https://bugs.webkit.org/show_bug.cgi?id=143358
     5
     6        Reviewed by Simon Fraser.
     7
     8        * Scripts/build-webkit: Add it to build-webkit.
     9
    1102015-05-06  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Tools/Scripts/build-webkit

    r180942 r183883  
    144144
    145145# Check that all the project directories are there.
    146 my @projects = ("Source/JavaScriptCore", "Source/WebCore", "Source/WebKit");
     146my @projects = ("Source/JavaScriptCore", "Source/PAL", "Source/WebCore", "Source/WebKit");
    147147
    148148# Build WTF as a separate static library on ports which support it.

  • trunk/WebKit.xcworkspace/contents.xcworkspacedata

    r182993 r183883  
    22<Workspace
    33   version = "1.0">
     4   <FileRef
     5      location = "group:Source/PAL/PAL.xcodeproj">
     6   </FileRef>
    47   <FileRef
    58      location = "group:Source/bmalloc/bmalloc.xcodeproj">
Note: See TracChangeset for help on using the changeset viewer.