Changeset 184446 in webkit


Ignore:
Timestamp:
May 17, 2015 11:16:58 PM (9 years ago)
Author:
Manuel Rego Casasnovas
Message:

[CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation
​https://bugs.webkit.org/show_bug.cgi?id=145021

Source/WebCore:

Like for flexboxes we've to take into account the scrollbar logical
width while computing the intrinsic min and max logical widths.

Reviewed by Sergio Villar Senin.

Test: fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths): Add scrollbar
logical width.

LayoutTests:

Reviewed by Sergio Villar Senin.

  • fast/css-grid-layout/compute-intrinsic-widths-scrollbar-expected.txt: Added.
  • fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r184440 r184446  
     12015-05-17  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation
     4        https://bugs.webkit.org/show_bug.cgi?id=145021
     5
     6        Reviewed by Sergio Villar Senin.
     7
     8        * fast/css-grid-layout/compute-intrinsic-widths-scrollbar-expected.txt: Added.
     9        * fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html: Added.
     10
    1112015-05-16  Zalan Bujtas  <zalan@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r184444 r184446  
     12015-05-17  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation
     4        https://bugs.webkit.org/show_bug.cgi?id=145021
     5
     6        Like for flexboxes we've to take into account the scrollbar logical
     7        width while computing the intrinsic min and max logical widths.
     8
     9        Reviewed by Sergio Villar Senin.
     10
     11        Test: fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html
     12
     13        * rendering/RenderGrid.cpp:
     14        (WebCore::RenderGrid::computeIntrinsicLogicalWidths): Add scrollbar
     15        logical width.
     16
    1172015-05-17  Xabier Rodriguez Calvar  <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
    218

  • trunk/Source/WebCore/rendering/RenderGrid.cpp

    r183660 r184446  
    302302        minLogicalWidth += minTrackBreadth;
    303303        maxLogicalWidth += maxTrackBreadth;
    304 
    305         // FIXME: This should add in the scrollbarWidth (e.g. see RenderFlexibleBox).
    306     }
     304    }
     305
     306    LayoutUnit scrollbarWidth = intrinsicScrollbarLogicalWidth();
     307    minLogicalWidth += scrollbarWidth;
     308    maxLogicalWidth += scrollbarWidth;
    307309
    308310    if (!wasPopulated)
Note: See TracChangeset for help on using the changeset viewer.