Changeset 184765 in webkit


Ignore:
Timestamp:
May 22, 2015 1:03:34 AM (9 years ago)
Author:
jdiggs@igalia.com
Message:

AX: Figure out why list-detection2.html test fails on GTK
https://bugs.webkit.org/show_bug.cgi?id=145273

Reviewed by Chris Fleizach.

Source/WebCore:

Platforms which expose rendered text content through the parent element "ignore" the
child renderers. This was causing AccessibilityList::childHasPseudoVisibleListItemMarker
to fail, which in turn caused the list detection heuristic to fail. Therefore add one
final check to this method to look for non-empty, non-whitespace text under the ::before
pseudo element.

No new tests; list-detection2.html now passes on GTK.

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):

LayoutTests:

  • platform/gtk/TestExpectations: Removed list-detection2.html from the list of expected failures.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r184754 r184765  
     12015-05-22  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: Figure out why list-detection2.html test fails on GTK
     4        https://bugs.webkit.org/show_bug.cgi?id=145273
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * platform/gtk/TestExpectations: Removed list-detection2.html from the list of expected failures.
     9
    1102015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
    211
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r184754 r184765  
    492492
    493493webkit.org/b/141072 accessibility/frame-disconnect-textmarker-cache-crash.html [ Failure ]
    494 webkit.org/b/145273 accessibility/list-detection2.html [ Failure ]
    495494
    496495webkit.org/b/141423 css3/calc/line-height.html [ Failure ]
  • trunk/Source/WebCore/ChangeLog

    r184760 r184765  
     12015-05-22  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: Figure out why list-detection2.html test fails on GTK
     4        https://bugs.webkit.org/show_bug.cgi?id=145273
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Platforms which expose rendered text content through the parent element "ignore" the
     9        child renderers. This was causing AccessibilityList::childHasPseudoVisibleListItemMarker
     10        to fail, which in turn caused the list detection heuristic to fail. Therefore add one
     11        final check to this method to look for non-empty, non-whitespace text under the ::before
     12        pseudo element.
     13
     14        No new tests; list-detection2.html now passes on GTK.
     15
     16        * accessibility/AccessibilityList.cpp:
     17        (WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
     18
    1192015-05-21  Jer Noble  <jer.noble@apple.com>
    220
  • trunk/Source/WebCore/accessibility/AccessibilityList.cpp

    r184676 r184765  
    118118    }
    119119   
    120     return false;
     120    // Platforms which expose rendered text content through the parent element will treat
     121    // those renderers as "ignored" objects.
     122    String text = axObj->textUnderElement();
     123    return !text.isEmpty() && !text.containsOnlyWhitespace();
    121124}
    122125   
Note: See TracChangeset for help on using the changeset viewer.