Changeset 184801 in webkit

Timestamp:

May 22, 2015 4:44:18 PM (9 years ago)

Author:

jdiggs@igalia.com

Message:

AX: Figure out why list-detection2.html test fails on GTK
​https://bugs.webkit.org/show_bug.cgi?id=145273

Reviewed by Chris Fleizach.

Only consider the text under the pseudo element for GTK and EFL.
The other platforms expose rendered text content through their
own accessible objects. This will fix the crash on Windows until
it can be looked into properly.

No new tests. This should stop list-detection2.html to stop crashing on Windows.

• accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityList.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-22  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        AX: Figure out why list-detection2.html test fails on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=145273
+
+        Reviewed by Chris Fleizach.
+
+        Only consider the text under the pseudo element for GTK and EFL.
+        The other platforms expose rendered text content through their
+        own accessible objects. This will fix the crash on Windows until
+        it can be looked into properly.
+
+        No new tests. This should stop list-detection2.html to stop crashing on Windows.
+
+        * accessibility/AccessibilityList.cpp:
+        (WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
+
 2015-05-22  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityList.cpp

@@ -120 +120 @@
     // Platforms which expose rendered text content through the parent element will treat
     // those renderers as "ignored" objects.
+#if PLATFORM(GTK) || PLATFORM(EFL)
     String text = axObj->textUnderElement();
     return !text.isEmpty() && !text.containsOnlyWhitespace();
+#else
+    return false;
+#endif
 }