Changeset 185366 in webkit

Timestamp:

Jun 9, 2015 10:11:50 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

[SOUP] Network Cache: Give more priority to reads over writes in IO WorkQueue
​https://bugs.webkit.org/show_bug.cgi?id=145791

Reviewed by Sergio Villar Senin.

Keep using G_PRIORITY_DEFAULT for reads, but use
G_PRIORITY_DEFAULT_IDLE for writes now.

• NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::outputStreamWriteReadyCallback): Use
G_PRIORITY_DEFAULT_IDLE for write async operations.
(WebKit::NetworkCache::IOChannel::write): Pass
G_PRIORITY_DEFAULT_IDLE to runTaskInQueue().

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-06-09  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Network Cache: Give more priority to reads over writes in IO WorkQueue
+        https://bugs.webkit.org/show_bug.cgi?id=145791
+
+        Reviewed by Sergio Villar Senin.
+
+        Keep using G_PRIORITY_DEFAULT for reads, but use
+        G_PRIORITY_DEFAULT_IDLE for writes now.
+
+        * NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
+        (WebKit::NetworkCache::outputStreamWriteReadyCallback): Use
+        G_PRIORITY_DEFAULT_IDLE for write async operations.
+        (WebKit::NetworkCache::IOChannel::write): Pass
+        G_PRIORITY_DEFAULT_IDLE to runTaskInQueue().
+
 2015-06-09  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp

@@ -262 +262 @@
     // Use a local variable for the data buffer to pass it to g_output_stream_write_async(), because WriteAsyncData is released.
     auto data = asyncData->buffer->data;
-    g_output_stream_write_async(stream, data, pendingBytesToWrite, G_PRIORITY_DEFAULT, nullptr,
+    g_output_stream_write_async(stream, data, pendingBytesToWrite, G_PRIORITY_DEFAULT_IDLE, nullptr,
         reinterpret_cast<GAsyncReadyCallback>(outputStreamWriteReadyCallback), asyncData.release());
 }
@@ -286 +286 @@
     WriteAsyncData* asyncData = new WriteAsyncData { this, data.soupBuffer(), queue, completionHandler };
     // FIXME: implement offset.
-    g_output_stream_write_async(stream, asyncData->buffer->data, data.size(), G_PRIORITY_DEFAULT, nullptr,
+    g_output_stream_write_async(stream, asyncData->buffer->data, data.size(), G_PRIORITY_DEFAULT_IDLE, nullptr,
         reinterpret_cast<GAsyncReadyCallback>(outputStreamWriteReadyCallback), asyncData);
 }