Changeset 185560 in webkit

Timestamp:

Jun 15, 2015 11:55:39 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Media Session: Active participating elements can change while being iterated
​https://bugs.webkit.org/show_bug.cgi?id=145978

Patch by Matt Rajca <​mrajca@apple.com> on 2015-06-15
Reviewed by Alex Christensen.

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::togglePlayback): Iterate through a copy of m_activeParticipatingElements since its contents

can be modified in the loop.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediasession/MediaSession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-15  Matt Rajca  <mrajca@apple.com>
+
+        Media Session: Active participating elements can change while being iterated 
+        https://bugs.webkit.org/show_bug.cgi?id=145978
+
+        Reviewed by Alex Christensen.
+
+        * Modules/mediasession/MediaSession.cpp:
+        (WebCore::MediaSession::togglePlayback): Iterate through a copy of m_activeParticipatingElements since its contents
+          can be modified in the loop.
+
 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp

@@ -95 +95 @@
 void MediaSession::togglePlayback()
 {
-    for (auto* element : m_activeParticipatingElements) {
+    HashSet<HTMLMediaElement*> activeParticipatingElementsCopy = m_activeParticipatingElements;
+
+    for (auto* element : activeParticipatingElementsCopy) {
         if (element->paused())
             element->play();