Changeset 185649 in webkit
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r185648 r185649 1 2015-06-17 Chris Fleizach <cfleizach@apple.com> 2 3 AX: input role="spinbutton" gets skipped in voiceover 4 https://bugs.webkit.org/show_bug.cgi?id=145514 5 6 Reviewed by Mario Sanchez Prada. 7 8 SpinButton role was added, but left out of iOS. 9 To prevent this from happening again, explicitly list every role in the switch statement that 10 determines accessible visibility. 11 12 Test: platform/ios-simulator/accessibility/spinbutton.html 13 14 * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: 15 (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]): 16 (-[WebAccessibilityObjectWrapper isAccessibilityElement]): 17 1 18 2015-06-17 Xabier Rodriguez Calvar <calvaris@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr> 2 19 -
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
r185609 r185649 639 639 case ValueIndicatorRole: 640 640 case ImageRole: 641 case ImageMapLinkRole: 641 642 case ProgressIndicatorRole: 642 643 case MenuItemRole: 644 case MenuItemCheckboxRole: 645 case MenuItemRadioRole: 643 646 case IncrementorRole: 644 647 case ComboBoxRole: … … 650 653 case DocumentMathRole: 651 654 case HorizontalRuleRole: 655 case SliderThumbRole: 652 656 case SwitchRole: 653 657 case SearchFieldRole: 658 case SpinButtonRole: 654 659 return true; 655 660 case StaticTextRole: … … 683 688 FALLTHROUGH; 684 689 // All other elements are ignored on the iphone. 685 default: 686 case UnknownRole: 687 case TabGroupRole: 688 case ScrollAreaRole: 689 case TableRole: 690 case AnnotationRole: 690 691 case ApplicationRole: 691 case RadioGroupRole: 692 case ApplicationAlertRole: 693 case ApplicationAlertDialogRole: 694 case ApplicationDialogRole: 695 case ApplicationLogRole: 696 case ApplicationMarqueeRole: 697 case ApplicationStatusRole: 698 case ApplicationTimerRole: 699 case AudioRole: 700 case BlockquoteRole: 701 case BrowserRole: 702 case BusyIndicatorRole: 703 case CanvasRole: 704 case CaptionRole: 705 case CellRole: 706 case ColorWellRole: 707 case ColumnRole: 708 case ColumnHeaderRole: 709 case DefinitionRole: 710 case DescriptionListRole: 711 case DescriptionListTermRole: 712 case DescriptionListDetailRole: 713 case DetailsRole: 714 case DirectoryRole: 715 case DivRole: 716 case DocumentRole: 717 case DocumentArticleRole: 718 case DocumentNoteRole: 719 case DocumentRegionRole: 720 case DrawerRole: 721 case EditableTextRole: 722 case FooterRole: 723 case FormRole: 724 case GridRole: 725 case GrowAreaRole: 726 case HelpTagRole: 727 case IgnoredRole: 728 case InlineRole: 729 case LabelRole: 730 case LandmarkApplicationRole: 731 case LandmarkBannerRole: 732 case LandmarkComplementaryRole: 733 case LandmarkContentInfoRole: 734 case LandmarkMainRole: 735 case LandmarkNavigationRole: 736 case LandmarkSearchRole: 737 case LegendRole: 692 738 case ListRole: 693 739 case ListBoxRole: 740 case ListItemRole: 741 case MathElementRole: 742 case MatteRole: 743 case MenuRole: 744 case MenuBarRole: 745 case MenuListPopupRole: 746 case MenuListOptionRole: 747 case OutlineRole: 748 case ParagraphRole: 749 case PreRole: 750 case PresentationalRole: 751 case RadioGroupRole: 752 case RowHeaderRole: 753 case RowRole: 754 case RubyBaseRole: 755 case RubyBlockRole: 756 case RubyInlineRole: 757 case RubyRunRole: 758 case RubyTextRole: 759 case RulerRole: 760 case RulerMarkerRole: 761 case ScrollAreaRole: 694 762 case ScrollBarRole: 695 case MenuBarRole: 696 case MenuRole: 697 case ColumnRole: 698 case RowRole: 699 case ToolbarRole: 700 case BusyIndicatorRole: 701 case WindowRole: 702 case DrawerRole: 703 case SystemWideRole: 704 case OutlineRole: 705 case BrowserRole: 763 case SheetRole: 764 case SpinButtonPartRole: 706 765 case SplitGroupRole: 707 766 case SplitterRole: 708 case ColorWellRole: 709 case GrowAreaRole: 710 case SheetRole: 711 case HelpTagRole: 712 case MatteRole: 713 case RulerRole: 714 case RulerMarkerRole: 715 case GridRole: 767 case SummaryRole: 768 case SystemWideRole: 769 case SVGRootRole: 770 case TabGroupRole: 771 case TabListRole: 772 case TabPanelRole: 773 case TableRole: 774 case TableHeaderContainerRole: 775 case TreeRole: 776 case TreeItemRole: 777 case TreeGridRole: 778 case ToolbarRole: 779 case UnknownRole: 780 case UserInterfaceTooltipRole: 781 case VideoRole: 716 782 case WebAreaRole: 783 case WindowRole: 717 784 return false; 718 785 } 786 787 ASSERT_NOT_REACHED(); 788 return false; 719 789 } 720 790
Note: See TracChangeset
for help on using the changeset viewer.