Changeset 185800 in webkit

Timestamp:

Jun 20, 2015 3:47:39 PM (9 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Unable to select parent element in the DOM tree path bar
​https://bugs.webkit.org/show_bug.cgi?id=145810

Reviewed by Timothy Hatcher.

• UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView.prototype.get selectionPathComponents):

• UserInterface/Views/HierarchicalPathComponent.js:

(WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
(WebInspector.HierarchicalPathComponent.prototype._selectElementMouseUp):
(WebInspector.HierarchicalPathComponent.prototype._selectElementSelectionChanged):
(WebInspector.HierarchicalPathComponent):
(WebInspector.HierarchicalPathComponent.prototype._selectElementMouseDown): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeContentView.js (modified) (1 diff)
• UserInterface/Views/HierarchicalPathComponent.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-06-20  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Unable to select parent element in the DOM tree path bar
+        https://bugs.webkit.org/show_bug.cgi?id=145810
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/DOMTreeContentView.js:
+        (WebInspector.DOMTreeContentView.prototype.get selectionPathComponents):
+        * UserInterface/Views/HierarchicalPathComponent.js:
+        (WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
+        (WebInspector.HierarchicalPathComponent.prototype._selectElementMouseUp):
+        (WebInspector.HierarchicalPathComponent.prototype._selectElementSelectionChanged):
+        (WebInspector.HierarchicalPathComponent):
+        (WebInspector.HierarchicalPathComponent.prototype._selectElementMouseDown): Deleted.
+
 2015-06-19  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js

@@ -124 +124 @@
 
             var pathComponent = new WebInspector.DOMTreeElementPathComponent(treeElement, treeElement.representedObject);
-            pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.SiblingWasSelected, this._pathComponentSelected, this);
+            pathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this);
             pathComponents.unshift(pathComponent);
             treeElement = treeElement.parent;

trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js

@@ -85 +85 @@
     // Public
 
+    get selectedPathComponent()
+    {
+        var selectElement = this._selectElement[this._selectElement.selectedIndex];
+        return selectElement && selectElement._pathComponent || null;
+    }
+
     get element()
     {
@@ -306 +312 @@
     _selectElementMouseUp(event)
     {
-        this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.Clicked);
+        this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.Clicked, {pathComponent: this.selectedPathComponent});
     }
 
     _selectElementSelectionChanged(event)
     {
-        this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.SiblingWasSelected, {pathComponent: this._selectElement[this._selectElement.selectedIndex]._pathComponent});
+        this.dispatchEventToListeners(WebInspector.HierarchicalPathComponent.Event.SiblingWasSelected, {pathComponent: this.selectedPathComponent});
     }
 };