Changeset 185971 in webkit


Ignore:
Timestamp:
Jun 25, 2015 4:47:29 PM (9 years ago)
Author:
Brent Fulgham
Message:

[WIN] Enable WEB_TIMING API
​https://bugs.webkit.org/show_bug.cgi?id=146330
<rdar://problem/21530765>

Reviewed by Dean Jackson.

Source/WebCore:

Tested by internal HLS tests.

Enable WEB_TIMING features on Windows by activating the feature flag,
and correcting some build errors.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start): "setCollectionTimingData" is only
defined for PLATFORM(COCOA).

  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
The 'ResourceHandle::getConnectionTimingData' method is only defined
for PLATFORM(COCOA).

WebKitLibraries:

Enable WEB_TIMING features on Windows by activating the feature flag,
and correcting some build errors.

  • win/tools/vsprops/FeatureDefines.props: Enable feature flag.
  • win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r185969 r185971  
     12015-06-25  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [WIN] Enable WEB_TIMING API
     4        https://bugs.webkit.org/show_bug.cgi?id=146330
     5        <rdar://problem/21530765>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Tested by internal HLS tests.
     10
     11        Enable WEB_TIMING features on Windows by activating the feature flag,
     12        and correcting some build errors.
     13
     14        * platform/network/cf/ResourceHandleCFNet.cpp:
     15        (WebCore::ResourceHandle::start): "setCollectionTimingData" is only
     16        defined for PLATFORM(COCOA).
     17        * platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
     18        (WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
     19        The 'ResourceHandle::getConnectionTimingData' method is only defined
     20        for PLATFORM(COCOA).
     21
    1222015-06-25  Dean Jackson  <dino@apple.com>
    223

  • trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp

    r185264 r185971  
    253253    bool shouldUseCredentialStorage = !client() || client()->shouldUseCredentialStorage(this);
    254254
    255 #if ENABLE(WEB_TIMING)
     255#if ENABLE(WEB_TIMING) && PLATFORM(COCOA)
    256256    setCollectsTimingData();
    257257#endif

  • trunk/Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp

    r174127 r185971  
    146146   
    147147    ResourceResponse resourceResponse(cfResponse);
    148 #if ENABLE(WEB_TIMING)
     148#if PLATFORM(COCOA) && ENABLE(WEB_TIMING)
    149149    ResourceHandle::getConnectionTimingData(connection, resourceResponse.resourceLoadTiming());
    150150#else

  • trunk/WebKitLibraries/ChangeLog

    r184928 r185971  
     12015-06-25  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [WIN] Enable WEB_TIMING API
     4        https://bugs.webkit.org/show_bug.cgi?id=146330
     5        <rdar://problem/21530765>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Enable WEB_TIMING features on Windows by activating the feature flag,
     10        and correcting some build errors.
     11
     12        * win/tools/vsprops/FeatureDefines.props: Enable feature flag.
     13        * win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
     14
    1152015-05-27  Dean Jackson  <dino@apple.com>
    216

  • trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.props

    r184928 r185971  
    8383    <ENABLE_WEB_AUDIO />
    8484    <ENABLE_WEB_SOCKETS>ENABLE_WEB_SOCKETS</ENABLE_WEB_SOCKETS>
    85     <ENABLE_WEB_TIMING />
     85    <ENABLE_WEB_TIMING>ENABLE_WEB_TIMING</ENABLE_WEB_TIMING>
    8686    <ENABLE_WEBGL />
    8787    <ENABLE_WEBVTT_REGIONS>ENABLE_WEBVTT_REGIONS</ENABLE_WEBVTT_REGIONS>

  • trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props

    r184928 r185971  
    8383    <ENABLE_WEB_AUDIO />
    8484    <ENABLE_WEB_SOCKETS>ENABLE_WEB_SOCKETS</ENABLE_WEB_SOCKETS>
    85     <ENABLE_WEB_TIMING />
     85    <ENABLE_WEB_TIMING>ENABLE_WEB_TIMING</ENABLE_WEB_TIMING>
    8686    <ENABLE_WEBGL>ENABLE_WEBGL</ENABLE_WEBGL>
    8787    <ENABLE_WEBVTT_REGIONS>ENABLE_WEBVTT_REGIONS</ENABLE_WEBVTT_REGIONS>
Note: See TracChangeset for help on using the changeset viewer.