Changeset 186024 in webkit

Timestamp:

Jun 27, 2015 1:04:19 AM (9 years ago)

Author:

youenn.fablet@crf.canon.fr

Message:

[Streams API] Implement ReadableStreamController.desiredSize property
​https://bugs.webkit.org/show_bug.cgi?id=146311

Reviewed by Darin Adler.

Source/WebCore:

Covered by rebased tests.

• Modules/streams/ReadableStreamController.h: Adding desiredSize getter.

(WebCore::ReadableStreamController::desiredSize): Ditto.

• Modules/streams/ReadableStreamController.idl: Added desiredSize attribute.

LayoutTests:

• streams/reference-implementation/count-queuing-strategy-expected.txt:
• streams/reference-implementation/readable-stream-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt (modified) (1 diff)
• LayoutTests/streams/reference-implementation/readable-stream-expected.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/streams/ReadableStreamController.h (modified) (1 diff)
• Source/WebCore/Modules/streams/ReadableStreamController.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        [Streams API] Implement ReadableStreamController.desiredSize property
+        https://bugs.webkit.org/show_bug.cgi?id=146311
+
+        Reviewed by Darin Adler.
+
+        * streams/reference-implementation/count-queuing-strategy-expected.txt:
+        * streams/reference-implementation/readable-stream-expected.txt:
+
 2015-06-26  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt

@@ -4 +4 @@
 PASS CountQueuingStrategy instances have the correct properties 
 PASS Can construct a readable stream with a valid CountQueuingStrategy 
-FAIL Correctly governs the return value of a ReadableStream's enqueue function (HWM = 0) assert_equals: 0 reads, 0 enqueues: desiredSize should be 0 expected (number) 0 but got (undefined) undefined
-FAIL Correctly governs a ReadableStreamController's desiredSize property (HWM = 1) assert_equals: 0 reads, 0 enqueues: desiredSize should be 1 expected (number) 1 but got (undefined) undefined
-FAIL Correctly governs a ReadableStreamController's desiredSize property (HWM = 4) assert_equals: 0 reads, 0 enqueues: desiredSize should be 4 expected (number) 4 but got (undefined) undefined
+PASS Correctly governs the return value of a ReadableStream's enqueue function (HWM = 0) 
+PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 1) 
+PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 4) 
 

trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt

@@ -6 +6 @@
 PASS ReadableStream constructor can get initial garbage as cancel argument 
 PASS ReadableStream constructor can get initial garbage as pull argument 
-FAIL ReadableStream start should be called with the proper parameters assert_array_equals: the controller should have the right properties lengths differ, expected 5 got 4
-FAIL ReadableStream start controller parameter should be extensible assert_array_equals: prototype should have the right properties lengths differ, expected 5 got 4
+FAIL ReadableStream start should be called with the proper parameters assert_false: close should be non-enumerable expected false got true
+PASS ReadableStream start controller parameter should be extensible 
 PASS ReadableStream should be able to call start method within prototype chain of its source 
 PASS ReadableStream start should be able to return a promise 
@@ -27 +27 @@
 PASS ReadableStream: enqueue should throw the stored error when the stream is errored 
 PASS ReadableStream: should call underlying source methods as methods 
-FAIL ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue assert_equals: expected (number) 1 but got (undefined) undefined
-FAIL ReadableStream strategies: the default strategy should continue giving desiredSize of 1 if the chunks are read immediately assert_equals: desiredSize should start at 1 expected (number) 1 but got (undefined) undefined
+PASS ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue 
+PASS ReadableStream strategies: the default strategy should continue giving desiredSize of 1 if the chunks are read immediately 
 PASS ReadableStream integration test: adapting a random push source 
 PASS ReadableStream integration test: adapting a sync pull source 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        [Streams API] Implement ReadableStreamController.desiredSize property
+        https://bugs.webkit.org/show_bug.cgi?id=146311
+
+        Reviewed by Darin Adler.
+
+        Covered by rebased tests.
+
+        * Modules/streams/ReadableStreamController.h: Adding desiredSize getter.
+        (WebCore::ReadableStreamController::desiredSize): Ditto.
+        * Modules/streams/ReadableStreamController.idl: Added desiredSize attribute.
+
 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/Modules/streams/ReadableStreamController.h

@@ -50 +50 @@
     void deref() { m_stream.deref(); }
 
+    double desiredSize() const { return m_stream.desiredSize(); }
+
 private:
     ReadableJSStream& m_stream;

trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl

@@ -37 +37 @@
     [Custom, RaisesException] void close();
     [Custom, RaisesException] void error(any error);
+
+    readonly attribute double desiredSize;
 };