Changeset 186084 in webkit

Timestamp:

Jun 29, 2015 2:01:29 PM (9 years ago)

Author:

mrajca@apple.com

Message:

MediaSession: use a HashSet for the collection of participating elements
​https://bugs.webkit.org/show_bug.cgi?id=146421

Reviewed by Eric Carlson.

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::addMediaElement):
(WebCore::MediaSession::removeMediaElement):

• Modules/mediasession/MediaSession.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediasession/MediaSession.cpp (modified) (2 diffs)
• Modules/mediasession/MediaSession.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-29  Matt Rajca  <mrajca@apple.com>
+
+        MediaSession: use a HashSet for the collection of participating elements
+        https://bugs.webkit.org/show_bug.cgi?id=146421
+
+        Reviewed by Eric Carlson.
+
+        * Modules/mediasession/MediaSession.cpp:
+        (WebCore::MediaSession::addMediaElement):
+        (WebCore::MediaSession::removeMediaElement):
+        * Modules/mediasession/MediaSession.h:
+
 2015-06-29  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp

@@ -108 +108 @@
 {
     ASSERT(!m_participatingElements.contains(&element));
-    m_participatingElements.append(&element);
+    m_participatingElements.add(&element);
 }
 
@@ -114 +114 @@
 {
     ASSERT(m_participatingElements.contains(&element));
-    m_participatingElements.remove(m_participatingElements.find(&element));
+    m_participatingElements.remove(&element);
 }
 

trunk/Source/WebCore/Modules/mediasession/MediaSession.h

@@ -93 +93 @@
 
     State m_currentState { State::Idle };
-    Vector<HTMLMediaElement*> m_participatingElements;
+    HashSet<HTMLMediaElement*> m_participatingElements;
     HashSet<HTMLMediaElement*> m_activeParticipatingElements;
     HashSet<HTMLMediaElement*>* m_iteratedActiveParticipatingElements { nullptr };