Changeset 186113 in webkit

Timestamp:

Jun 30, 2015 2:53:40 AM (9 years ago)

Author:

calvaris@igalia.com

Message:

[Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)
​https://bugs.webkit.org/show_bug.cgi?id=146408

Reviewed by Darin Adler.

Source/WebCore:

Current tests cover the case already.

• Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::pull): Call finishPull() in a postTask to delay it and simulate the promise
resolution.

LayoutTests:

• streams/reference-implementation/readable-stream-expected.txt: Updated expectation to PASS

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/streams/reference-implementation/readable-stream-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/streams/ReadableStream.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-06-30  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)
+        https://bugs.webkit.org/show_bug.cgi?id=146408
+
+        Reviewed by Darin Adler.
+
+        * streams/reference-implementation/readable-stream-expected.txt: Updated expectation to PASS
+
 2015-06-30  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt

@@ -14 +14 @@
 PASS ReadableStream: if pull rejects, it should error the stream 
 PASS ReadableStream: should only call pull once upon starting the stream 
-FAIL ReadableStream: should call pull when trying to read from a started, empty stream assert_equals: pull should be called again in reaction to calling read expected 2 but got 3
+PASS ReadableStream: should call pull when trying to read from a started, empty stream 
 PASS ReadableStream: should only call pull once on a non-empty stream read from before start fulfills 
 PASS ReadableStream: should only call pull once on a non-empty stream read from after start fulfills 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-30  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)
+        https://bugs.webkit.org/show_bug.cgi?id=146408
+
+        Reviewed by Darin Adler.
+
+        Current tests cover the case already.
+
+        * Modules/streams/ReadableStream.cpp:
+        (WebCore::ReadableStream::pull): Call finishPull() in a postTask to delay it and simulate the promise
+        resolution.
+
 2015-06-30  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/Modules/streams/ReadableStream.cpp

@@ -35 +35 @@
 #include "ExceptionCode.h"
 #include "ReadableStreamReader.h"
+#include "ScriptExecutionContext.h"
 #include <runtime/JSCJSValueInlines.h>
 #include <wtf/RefCountedLeakCounter.h>
@@ -133 +134 @@
 
     m_isPulling = true;
-    if (doPull())
-        finishPulling();
+    if (doPull()) {
+        RefPtr<ReadableStream> protectedStream(this);
+        scriptExecutionContext()->postTask([protectedStream](ScriptExecutionContext&) {
+            protectedStream->finishPulling();
+        });
+    }
 }