Changeset 186263 in webkit

Timestamp:

Jul 3, 2015 1:39:08 PM (9 years ago)

Author:

mario@webkit.org

Message:

Crash on xLarge memory allocation using bmalloc on 32bit systems
​https://bugs.webkit.org/show_bug.cgi?id=146440

Reviewed by Gustavo Noronha Silva.

Disable the gcc's -ftree-sra optimization (automatically enabled
with -O1 and higher levels) for WebCore and 32bit Intel architectures,
as that causes the crash in bmalloc when allocating large amounts of
memory from the texture mapper's tiled backing store implementation.

• CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.

Location:

trunk/Source/WebCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebCore/CMakeLists.txt

@@ -3575 +3575 @@
 set_target_properties(WebCore PROPERTIES FOLDER "WebCore")
 
+# The -ftree-sra optimization (implicit with -O2) causes crashes when
+# allocating large chunks of memory using bmalloc on Intel 32bit.
+# See https://bugs.webkit.org/show_bug.cgi?id=146440
+string(TOLOWER ${CMAKE_HOST_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR)
+if (CMAKE_COMPILER_IS_GNUCXX AND "${LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR}" MATCHES "(i[3-6]86|x86)$")
+    ADD_TARGET_PROPERTIES(WebCore COMPILE_FLAGS "-fno-tree-sra")
+endif ()
+
 if (WebCore_OUTPUT_NAME)
     set_target_properties(WebCore PROPERTIES OUTPUT_NAME ${WebCore_OUTPUT_NAME})

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-07-03  Mario Sanchez Prada  <mario@endlessm.com>
+
+        Crash on xLarge memory allocation using bmalloc on 32bit systems
+        https://bugs.webkit.org/show_bug.cgi?id=146440
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Disable the gcc's -ftree-sra optimization (automatically enabled
+        with -O1 and higher levels) for WebCore and 32bit Intel architectures,
+        as that causes the crash in bmalloc when allocating large amounts of
+        memory from the texture mapper's tiled backing store implementation.
+
+        * CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.
+
 2015-07-03  Csaba Osztrogonác  <ossy@webkit.org>