Changeset 18643 in webkit


Ignore:
Timestamp:
Jan 7, 2007 12:37:24 AM (17 years ago)
Author:
rwlbuis
Message:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12125
overflow attribute of the symbol element not respected

Copy the attribute map to the cloned node so the overflow on
the symbol is respected.

Location:
trunk
Files:
4 added
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r18642 r18643  
     12007-01-06  Rob Buis  <buis@kde.org>
     2
     3        Reviewed by Darin.
     4
     5        Testcase for:
     6        http://bugs.webkit.org/show_bug.cgi?id=12125
     7        overflow attribute of the symbol element not respected
     8
     9        Also including changed testresults (improvements).
     10
     11        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
     12        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
     13        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
     14        * svg/carto.net/window-expected.checksum:
     15        * svg/carto.net/window-expected.png:
     16        * svg/custom/use-symbol-overflow-expected.checksum: Added.
     17        * svg/custom/use-symbol-overflow-expected.png: Added.
     18        * svg/custom/use-symbol-overflow-expected.txt: Added.
     19        * svg/custom/use-symbol-overflow.svg: Added.
     20
    1212007-01-06  Darin Adler  <darin@apple.com>
    222
  • trunk/LayoutTests/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum

    r18436 r18643  
    1 bb0634418a40c5de1cb822c8b4f3b419
     1a97920a94b38670d839c72a49c9cea9b
  • trunk/LayoutTests/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt

    r18436 r18643  
    66          RenderSVGContainer {use} at (0,0) size 1000x1000
    77            RenderSVGContainer {g} at (0,0) size 1000x1000
    8               RenderSVGContainer {svg} at (45,0) size 150x150
     8              RenderSVGContainer {svg} at (0,0) size 240x150
    99                RenderImage {image} at (0,0) size 1000x1000
    1010          RenderSVGContainer {use} at (240,150) size 1000x1000
    1111            RenderSVGContainer {g} at (240,150) size 1000x1000 [transform={m=((1.00,0.00)(0.00,1.00)) t=(240.00,150.00)}]
    12               RenderSVGContainer {svg} at (285,150) size 150x150
    13                 RenderPath {rect} at (285,150) size 75x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M0.00,0.00L500.00,0.00L500.00,500.00L0.00,500.00"]
    14                 RenderPath {rect} at (360,150) size 75x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M500.00,0.00L1000.00,0.00L1000.00,500.00L500.00,500.00"]
    15                 RenderPath {rect} at (285,225) size 75x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,500.00L500.00,500.00L500.00,1000.00L0.00,1000.00"]
    16                 RenderPath {rect} at (360,225) size 75x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M500.00,500.00L1000.00,500.00L1000.00,1000.00L500.00,1000.00"]
     12              RenderSVGContainer {svg} at (240,150) size 240x150
     13                RenderPath {rect} at (240,150) size 120x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M0.00,0.00L500.00,0.00L500.00,500.00L0.00,500.00"]
     14                RenderPath {rect} at (360,150) size 120x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M500.00,0.00L1000.00,0.00L1000.00,500.00L500.00,500.00"]
     15                RenderPath {rect} at (240,225) size 120x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,500.00L500.00,500.00L500.00,1000.00L0.00,1000.00"]
     16                RenderPath {rect} at (360,225) size 120x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M500.00,500.00L1000.00,500.00L1000.00,1000.00L500.00,1000.00"]
    1717      RenderSVGText {text} at (10,340) size 480x46
    1818        RenderSVGInlineText {#text} at (0,-36) size 264x46
  • trunk/LayoutTests/svg/carto.net/window-expected.checksum

    r18522 r18643  
    1 bf4f7249c62d8a4aca577ce3fbe6c978
     17a696a0b8d582b1e07fae7cdeb22121d
  • trunk/WebCore/ChangeLog

    r18641 r18643  
     12007-01-06  Rob Buis  <buis@kde.org>
     2
     3        Reviewed by Darin.
     4
     5        http://bugs.webkit.org/show_bug.cgi?id=12125
     6        overflow attribute of the symbol element not respected
     7
     8        Copy the attribute map to the cloned node so the overflow on
     9        the symbol is respected.
     10
     11        * ksvg2/svg/SVGUseElement.cpp:
     12        (WebCore::SVGUseElement::closeRenderer):
     13
    1142007-01-06  Eric Seidel  <eric@webkit.org>
    215
  • trunk/WebCore/ksvg2/svg/SVGUseElement.cpp

    r18428 r18643  
    114114        }
    115115        target->cloneChildNodes(dummy.get());
     116        *dummy->attributes() = *target->attributes();
    116117
    117118        RefPtr<SVGElement> dummy2 = new SVGDummyElement(SVGNames::gTag, document());
Note: See TracChangeset for help on using the changeset viewer.