Changeset 187095 in webkit

Timestamp:

Jul 20, 2015 10:33:50 PM (9 years ago)

Author:

Carlos Garcia Campos

Message:

Remove RenderTheme::shouldShowPlaceholderWhenFocused()
​https://bugs.webkit.org/show_bug.cgi?id=147104

Reviewed by Martin Robinson.

GTK+ is the only port that returns false in
shouldShowPlaceholderWhenFocused(). That's inconsistent with all
other browsers that show the placeholder text even for focused
entries in all platforms. We should change the GTK+ port
behaviour, but that would leave all implementations of
shouldShowPlaceholderWhenFocused returning true, so let's just
remove it.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Do not consider whether the entry is focused or not.

• platform/efl/RenderThemeEfl.h:
• rendering/RenderTheme.h:

(WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): Deleted.

• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldShowPlaceholderWhenFocused): Deleted.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): Deleted.

• rendering/RenderThemeSafari.h:

(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused): Deleted.

• rendering/RenderThemeWin.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLTextFormControlElement.cpp (modified) (1 diff)
• platform/efl/RenderThemeEfl.h (modified) (1 diff)
• rendering/RenderTheme.h (modified) (1 diff)
• rendering/RenderThemeIOS.h (modified) (1 diff)
• rendering/RenderThemeIOS.mm (modified) (1 diff)
• rendering/RenderThemeMac.h (modified) (1 diff)
• rendering/RenderThemeMac.mm (modified) (1 diff)
• rendering/RenderThemeSafari.h (modified) (1 diff)
• rendering/RenderThemeWin.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Remove RenderTheme::shouldShowPlaceholderWhenFocused()
+        https://bugs.webkit.org/show_bug.cgi?id=147104
+
+        Reviewed by Martin Robinson.
+
+        GTK+ is the only port that returns false in
+        shouldShowPlaceholderWhenFocused(). That's inconsistent with all
+        other browsers that show the placeholder text even for focused
+        entries in all platforms. We should change the GTK+ port
+        behaviour, but that would leave all implementations of
+        shouldShowPlaceholderWhenFocused returning true, so let's just
+        remove it.
+
+        * html/HTMLTextFormControlElement.cpp:
+        (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
+        Do not consider whether the entry is focused or not.
+        * platform/efl/RenderThemeEfl.h:
+        * rendering/RenderTheme.h:
+        (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): Deleted.
+        * rendering/RenderThemeIOS.h:
+        * rendering/RenderThemeIOS.mm:
+        (WebCore::RenderThemeIOS::shouldShowPlaceholderWhenFocused): Deleted.
+        * rendering/RenderThemeMac.h:
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): Deleted.
+        * rendering/RenderThemeSafari.h:
+        (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused): Deleted.
+        * rendering/RenderThemeWin.h:
+
 2015-07-20  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp

@@ -151 +151 @@
     // This function is used by the style resolver to match the :placeholder-shown pseudo class.
     // Since it is used for styling, it must not use any value depending on the style.
-    return supportsPlaceholder()
-        && isEmptyValue()
-        && !isPlaceholderEmpty()
-        && (document().focusedElement() != this || (document().page()->theme().shouldShowPlaceholderWhenFocused()));
+    return supportsPlaceholder() && isEmptyValue() && !isPlaceholderEmpty();
 }
 

trunk/Source/WebCore/platform/efl/RenderThemeEfl.h

@@ -176 +176 @@
     virtual bool supportsClosedCaptioning() const override { return true; }
 #endif
-    virtual bool shouldShowPlaceholderWhenFocused() const override { return true; }
 
     void setThemePath(const String&);

trunk/Source/WebCore/rendering/RenderTheme.h

@@ -229 +229 @@
 #endif
 
-    virtual bool shouldShowPlaceholderWhenFocused() const { return false; }
     virtual bool shouldHaveSpinButton(HTMLInputElement&) const;
     virtual bool shouldHaveCapsLockIndicator(HTMLInputElement&) const;

trunk/Source/WebCore/rendering/RenderThemeIOS.h

@@ -103 +103 @@
 #endif
 
-    virtual bool shouldShowPlaceholderWhenFocused() const override;
     virtual bool shouldHaveSpinButton(HTMLInputElement&) const override;
     virtual bool shouldHaveCapsLockIndicator(HTMLInputElement&) const override;

trunk/Source/WebCore/rendering/RenderThemeIOS.mm

@@ -1074 +1074 @@
 }
 
-bool RenderThemeIOS::shouldShowPlaceholderWhenFocused() const
-{
-    return true;
-}
-
 bool RenderThemeIOS::shouldHaveSpinButton(HTMLInputElement&) const
 {

trunk/Source/WebCore/rendering/RenderThemeMac.h

@@ -163 +163 @@
 #endif
 
-    virtual bool shouldShowPlaceholderWhenFocused() const override;
     virtual bool shouldHaveCapsLockIndicator(HTMLInputElement&) const override;
 

trunk/Source/WebCore/rendering/RenderThemeMac.mm

@@ -1937 +1937 @@
 }
 
-bool RenderThemeMac::shouldShowPlaceholderWhenFocused() const
-{
-    return true;
-}
-
 bool RenderThemeMac::shouldHaveCapsLockIndicator(HTMLInputElement& element) const
 {

trunk/Source/WebCore/rendering/RenderThemeSafari.h

@@ -141 +141 @@
 #endif
 
-    virtual bool shouldShowPlaceholderWhenFocused() const { return true; }
-
 private:
     RenderThemeSafari();

trunk/Source/WebCore/rendering/RenderThemeWin.h

@@ -135 +135 @@
 #endif
 
-    virtual bool shouldShowPlaceholderWhenFocused() const override { return true; }
-
 private:
     enum ControlSubPart {