Changeset 187790 in webkit


Ignore:
Timestamp:
Aug 3, 2015 5:30:45 PM (9 years ago)
Author:
mrajca@apple.com
Message:

Media Session: let UI clients query whether a media element is paused
​https://bugs.webkit.org/show_bug.cgi?id=147588

Reviewed by Tim Horton.

WebCore:

  • page/Page.cpp:

(WebCore::Page::isMediaElementPaused): Determine if the media element with the given ID is paused.

  • page/Page.h:

WebKit2: Added plumbing to determine if a page's media element is paused.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isMediaElementPaused):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::isMediaElementPaused):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
Location:
trunk/Source
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r187776 r187790  
     12015-08-03  Matt Rajca  <mrajca@apple.com>
     2
     3        Media Session: let UI clients query whether a media element is paused
     4        https://bugs.webkit.org/show_bug.cgi?id=147588
     5
     6        Reviewed by Tim Horton.
     7
     8        * page/Page.cpp:
     9        (WebCore::Page::isMediaElementPaused): Determine if the media element with the given ID is paused.
     10        * page/Page.h:
     11
    1122015-08-03  Eric Carlson  <eric.carlson@apple.com>
    213

  • trunk/Source/WebCore/page/Page.cpp

    r187251 r187790  
    12251225    }
    12261226}
     1227
     1228bool Page::isMediaElementPaused(uint64_t elementID)
     1229{
     1230    if (HTMLMediaElement* element = HTMLMediaElement::elementWithID(elementID))
     1231        return element->paused();
     1232
     1233    ASSERT_NOT_REACHED();
     1234    return true;
     1235}
    12271236#endif
    12281237

  • trunk/Source/WebCore/page/Page.h

    r187358 r187790  
    443443#if ENABLE(MEDIA_SESSION)
    444444    WEBCORE_EXPORT void handleMediaEvent(MediaEventType);
     445    WEBCORE_EXPORT bool isMediaElementPaused(uint64_t);
    445446#endif
    446447

  • trunk/Source/WebKit2/ChangeLog

    r187765 r187790  
     12015-08-03  Matt Rajca  <mrajca@apple.com>
     2
     3        Media Session: let UI clients query whether a media element is paused
     4        https://bugs.webkit.org/show_bug.cgi?id=147588
     5
     6        Reviewed by Tim Horton.
     7
     8        Added plumbing to determine if a page's media element is paused.
     9
     10        * UIProcess/WebPageProxy.cpp:
     11        (WebKit::WebPageProxy::isMediaElementPaused):
     12        * UIProcess/WebPageProxy.h:
     13        * WebProcess/WebPage/WebPage.cpp:
     14        (WebKit::WebPage::isMediaElementPaused):
     15        * WebProcess/WebPage/WebPage.h:
     16        * WebProcess/WebPage/WebPage.messages.in:
     17
    1182015-08-03  Chris Dumez  <cdumez@apple.com>
    219

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r187713 r187790  
    38863886    m_process->send(Messages::WebPage::HandleMediaEvent(eventType), m_pageID);
    38873887}
     3888
     3889void WebPageProxy::isMediaElementPaused(uint64_t elementID, uint64_t callbackID)
     3890{
     3891    if (!isValid())
     3892        return;
     3893
     3894    m_process->send(Messages::WebPage::IsMediaElementPaused(elementID, callbackID), m_pageID);
     3895}
    38883896#endif
    38893897

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.h

    r187713 r187790  
    947947    bool hasMediaSessionWithActiveMediaElements() const { return m_hasMediaSessionWithActiveMediaElements; }
    948948    void handleMediaEvent(WebCore::MediaEventType);
     949    void isMediaElementPaused(uint64_t, uint64_t);
    949950#endif
    950951

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r187751 r187790  
    40694069    m_page->handleMediaEvent(static_cast<MediaEventType>(eventType));
    40704070}
     4071
     4072void WebPage::isMediaElementPaused(uint64_t elementID, uint64_t callbackID)
     4073{
     4074    bool paused = m_page->isMediaElementPaused(elementID);
     4075    send(Messages::WebPageProxy::UnsignedCallback(paused, callbackID));
     4076}
    40714077#endif
    40724078

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h

    r187522 r187790  
    751751#if ENABLE(MEDIA_SESSION)
    752752    void handleMediaEvent(uint32_t /* WebCore::MediaEventType */);
     753    void isMediaElementPaused(uint64_t, uint64_t);
    753754#endif
    754755

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in

    r187522 r187790  
    317317#if ENABLE(MEDIA_SESSION)
    318318    HandleMediaEvent(uint32_t eventType)
     319    IsMediaElementPaused(uint64_t elementID, uint64_t callbackID)
    319320#endif
    320321
Note: See TracChangeset for help on using the changeset viewer.