Changeset 187935 in webkit

Timestamp:

Aug 4, 2015 8:38:58 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

AX: tree item children returned from ranged getter are different from full array of children
​https://bugs.webkit.org/show_bug.cgi?id=147660

Source/WebCore:

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-04
Reviewed by Chris Fleizach.

Add an isTreeItem() check in ranged element getter so that it matches the logic in
the getter for the full children array. This prevents returning a row as a child
when only the rows contents should be returned. This prevents navigation issues on
websites without aria outlines.

Test: accessibility/mac/aria-tree-item-children.html

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

LayoutTests:

Add an isTreeItem() check in ranged element getter so that it matches the logic in
the getter for the full children array. This prevents returning a row as a child
when only the rows contents should be returned. This prevents navigation issues on
websites without aria outlines.

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-04
Reviewed by Chris Fleizach.

• accessibility/mac/aria-tree-item-children-expected.txt: Added.
• accessibility/mac/aria-tree-item-children.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/mac/aria-tree-item-children-expected.txt (added)
• LayoutTests/accessibility/mac/aria-tree-item-children.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-08-04  Doug Russell  <d_russell@apple.com>
+
+        AX: tree item children returned from ranged getter are different from full array of children
+        https://bugs.webkit.org/show_bug.cgi?id=147660
+
+        Add an isTreeItem() check in ranged element getter so that it matches the logic in 
+        the getter for the full children array. This prevents returning a row as a child
+        when only the rows contents should be returned. This prevents navigation issues on
+        websites without aria outlines.
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/mac/aria-tree-item-children-expected.txt: Added.
+        * accessibility/mac/aria-tree-item-children.html: Added.
+
 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-08-04  Doug Russell  <d_russell@apple.com>
+
+        AX: tree item children returned from ranged getter are different from full array of children
+        https://bugs.webkit.org/show_bug.cgi?id=147660
+
+        Reviewed by Chris Fleizach.
+
+        Add an isTreeItem() check in ranged element getter so that it matches the logic in 
+        the getter for the full children array. This prevents returning a row as a child
+        when only the rows contents should be returned. This prevents navigation issues on
+        websites without aria outlines.
+
+        Test: accessibility/mac/aria-tree-item-children.html
+
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
+
 2015-08-04  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

@@ -4049 +4049 @@
             NSUInteger arrayLength = std::min(childCount - index, maxCount);
             return [children subarrayWithRange:NSMakeRange(index, arrayLength)];
-        } else if (m_object->isTree()) {
-            // Tree objects return their rows as their children. We can use the original method in this case.
+        } else if (m_object->isTree() || m_object->isTreeItem()) {
+            // Tree objects return their rows as their children & tree items return their contents sans rows.
+            // We can use the original method in this case.
             return [super accessibilityArrayAttributeValues:attribute index:index maxCount:maxCount];
         }