Changeset 188304 in webkit

Timestamp:

Aug 11, 2015 3:47:30 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
for internalTrac.
​https://bugs.webkit.org/show_bug.cgi?id=147805

Patch by Jason Marcell <​jmarcell@apple.com> on 2015-08-11
Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
Dashboard.Repository.Internal.trac for internalTrac.
(BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
respectively.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
(BuildbotQueueView.prototype.revisionContentForIteration): Substituted
Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
internalTrac.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

(Analyzer): Ditto.
(Analyzer.prototype.analyze): Ditto.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (modified) (4 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js

@@ -39 +39 @@
     }.bind(this));
 
-    webkitTrac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
-    if (typeof internalTrac != "undefined")
-        internalTrac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
+    Dashboard.Repository.OpenSource.trac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
+    if (typeof Dashboard.Repository.Internal.trac != "undefined")
+        Dashboard.Repository.Internal.trac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
 };
 
@@ -77 +77 @@
             return;
 
+        var webkitTrac = Dashboard.Repository.OpenSource.trac;
+        var internalTrac = Dashboard.Repository.Internal.trac;
         var latestRecordedOpenSourceRevisionNumber = webkitTrac.latestRecordedRevisionNumber;
         if (!latestRecordedOpenSourceRevisionNumber || webkitTrac.oldestRecordedRevisionNumber > latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name]) {
@@ -154 +156 @@
         content.className = "commit-history-popover";
 
+        var webkitTrac = Dashboard.Repository.OpenSource.trac;
+        var internalTrac = Dashboard.Repository.Internal.trac;
         var linesForOpenSource = this._popoverLinesForCommitRange(webkitTrac, queue.branch.openSource, latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name] + 1, webkitTrac.latestRecordedRevisionNumber);
         for (var i = 0; i != linesForOpenSource.length; ++i)
@@ -263 +267 @@
         console.assert(iteration.revision[Dashboard.Repository.OpenSource.name]);
 
-        var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, Dashboard.Repository.OpenSource.name, webkitTrac);
+        var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration,
+            Dashboard.Repository.OpenSource.name, Dashboard.Repository.OpenSource.trac);
 
         if (!iteration.revision[Dashboard.Repository.Internal.name])
             return openSourceContent;
 
-        var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, Dashboard.Repository.Internal.name, internalTrac);
+        var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration,
+            Dashboard.Repository.Internal.name, Dashboard.Repository.Internal.trac);
 
         var fragment = document.createDocumentFragment();

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js

@@ -26 +26 @@
 var settings = new Settings;
 var buildbots = [ new WebKitBuildbot ];
-var webkitTrac = new Trac("https://trac.webkit.org/");
+Dashboard.Repository.OpenSource.trac = new Trac("https://trac.webkit.org/");
 if (typeof Bugzilla !== "undefined")
     var bugzilla = new Bugzilla;

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js

@@ -297 +297 @@
 }
 
-webkitTrac.startPeriodicUpdates();
-if (typeof internalTrac !== "undefined")
-    internalTrac.startPeriodicUpdates();
+Dashboard.Repository.OpenSource.trac.startPeriodicUpdates();
+if (typeof Dashboard.Repository.Internal.trac !== "undefined")
+    Dashboard.Repository.Internal.trac.startPeriodicUpdates();
 
 document.addEventListener("DOMContentLoaded", documentReady);

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js

@@ -31 +31 @@
     this._queueBeingLoaded = null;
 
-    webkitTrac.addEventListener(Trac.Event.Loaded, this._loadedFromTrac, this);
+    Dashboard.Repository.OpenSource.trac.addEventListener(Trac.Event.Loaded, this._loadedFromTrac, this);
 };
 
@@ -78 +78 @@
         }, this);
 
-        webkitTrac.load(this._rangeStartTime, this._rangeEndTime);
+        Dashboard.Repository.OpenSource.trac.load(this._rangeStartTime, this._rangeEndTime);
 
         bubbleQueueServer.loadProcessingTimes(this._rangeStartTime, this._rangeEndTime, this._loadedBubblesTiming.bind(this));
@@ -265 +265 @@
         var worstOwnTimeRevision;
 
-        webkitTrac.recordedCommits.forEach(function(revision) {
+        Dashboard.Repository.OpenSource.trac.recordedCommits.forEach(function(revision) {
             if (revision.date < this._rangeStartTime || revision.date >= this._rangeEndTime)
                 return;

trunk/Tools/ChangeLog

@@ +1 @@
+2015-08-11  Jason Marcell  <jmarcell@apple.com>
+
+        Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
+        for internalTrac.
+        https://bugs.webkit.org/show_bug.cgi?id=147805
+
+        Reviewed by Daniel Bates.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+        (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
+        Dashboard.Repository.Internal.trac for internalTrac.
+        (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
+        and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
+        respectively.
+        (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
+        (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
+        Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
+        internalTrac.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+        (Analyzer): Ditto.
+        (Analyzer.prototype.analyze): Ditto.
+
 2015-08-11  Filip Pizlo  <fpizlo@apple.com>