Changeset 188682 in webkit

Timestamp:

Aug 19, 2015 10:03:06 PM (9 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Visual styles panel does not work with pseudo-elements
​https://bugs.webkit.org/show_bug.cgi?id=148187

Reviewed by Timothy Hatcher.

If the inline style does not exist, such as for pseudo-elements, default to the first matched rule.

• UserInterface/Views/VisualStyleSelectorSection.js:

(WebInspector.VisualStyleSelectorSection.prototype.update):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/VisualStyleSelectorSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-08-19  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Visual styles panel does not work with pseudo-elements
+        https://bugs.webkit.org/show_bug.cgi?id=148187
+
+        Reviewed by Timothy Hatcher.
+
+        If the inline style does not exist, such as for pseudo-elements, default to the first matched rule.
+
+        * UserInterface/Views/VisualStyleSelectorSection.js:
+        (WebInspector.VisualStyleSelectorSection.prototype.update):
+
 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js

@@ -156 +156 @@
         }
 
-        if (!this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol])
-            this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol] = this._nodeStyles.inlineStyle;
-
-        // Inline Style
-        createSelectorItem.call(this, this._nodeStyles.inlineStyle, WebInspector.UIString("This Element"));
+        if (this._nodeStyles.inlineStyle) {
+            if (!this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol])
+                this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol] = this._nodeStyles.inlineStyle;
+
+            // Inline Style
+            createSelectorItem.call(this, this._nodeStyles.inlineStyle, WebInspector.UIString("This Element"));
+        } else if (!this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol])
+            this._nodeStyles[WebInspector.VisualStyleSelectorSection.LastSelectedRuleSymbol] = this._nodeStyles.matchedRules[0].style;
 
         // Matched Rules