Changeset 188770 in webkit

Timestamp:

Aug 21, 2015 1:00:48 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

AX: Fix accessibility/mac/search-with-frames.html test
​https://bugs.webkit.org/show_bug.cgi?id=148313

Patch by Nan Wang <​n_wang@apple.com> on 2015-08-21
Reviewed by Chris Fleizach.

uiElementForSearchPredicate function needs five parameters for DumpRenderTree.

• accessibility/mac/search-with-frames.html:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• accessibility/mac/search-with-frames.html (modified) (3 diffs)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-08-21  Nan Wang  <n_wang@apple.com>
+
+        AX: Fix accessibility/mac/search-with-frames.html test
+        https://bugs.webkit.org/show_bug.cgi?id=148313
+
+        Reviewed by Chris Fleizach.
+
+        uiElementForSearchPredicate function needs five parameters for DumpRenderTree.
+
+        * accessibility/mac/search-with-frames.html:
+        * platform/mac/TestExpectations:
+
 2015-08-21  Doug Russell  <d_russell@apple.com>
 

trunk/LayoutTests/accessibility/mac/search-with-frames.html

@@ -46 +46 @@
           if (e.target.id == "frame3") {
              ifrm.onload = function() {
-                 runTest();
+                 // runTest() might run on the same call stack and the frame is not actually finished loading.
+                 setTimeout("runTest()", 0);
              };
           }
@@ -66 +67 @@
         // Search for the buttons. This tests searching through the frames.
         searchKey = "AXButtonSearchKey";
-        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button1'");
 
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button2'");
 
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button3'");
 
         // Now search backwards.
-        resultElement = body.uiElementForSearchPredicate(resultElement, false, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, false, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button2'");
@@ -85 +86 @@
         // Search for the frames. First one is frame1
         searchKey = "AXFrameSearchKey";
-        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXWebArea'");
         shouldBe("resultElement.description", "'AXDescription: frame1'");
 
         // Next we should find the frame inside of frame1.
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXWebArea'");
         shouldBe("resultElement.description", "'AXDescription: frame1a'");
 
         // Then we should find the frame after frame1.
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXWebArea'");
         shouldBe("resultElement.description", "'AXDescription: frame2'");

trunk/LayoutTests/platform/mac/TestExpectations

@@ -485 +485 @@
 http/tests/misc/willCacheResponse-delegate-callback.html [ Failure ]
 http/tests/xmlhttprequest/basic-auth-nopassword.html [ Failure ]
-
-accessibility/mac/search-with-frames.html [ Pass Failure ]
 
 # --- Plugins ---