Changeset 188946 in webkit

Timestamp:

Aug 25, 2015 11:29:48 PM (9 years ago)

Author:

BJ Burg

Message:

Web Inspector: message dispatch metrics should use high-resolution timing data
​https://bugs.webkit.org/show_bug.cgi?id=135467

Reviewed by Timothy Hatcher.

Use performance.now if it's available, otherwise fallback to Date.now().
Format timestamps with fixed decimal point, and sprinkle some ES6.

• UserInterface/Base/Utilities.js:

(timestamp): Added.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
(InspectorBackendClass.prototype._dispatchEvent):

• UserInterface/Protocol/MessageDispatcher.js:

(WebInspector.dispatchNextQueuedMessageFromBackend):
(WebInspector.dispatchMessageFromBackend): Be consistent about using this.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Utilities.js (modified) (1 diff)
• UserInterface/Protocol/InspectorBackend.js (modified) (6 diffs)
• UserInterface/Protocol/MessageDispatcher.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-08-25  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: message dispatch metrics should use high-resolution timing data
+        https://bugs.webkit.org/show_bug.cgi?id=135467
+
+        Reviewed by Timothy Hatcher.
+
+        Use performance.now if it's available, otherwise fallback to Date.now().
+        Format timestamps with fixed decimal point, and sprinkle some ES6.
+
+        * UserInterface/Base/Utilities.js:
+        (timestamp): Added.
+        * UserInterface/Protocol/InspectorBackend.js:
+        (InspectorBackendClass):
+        (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
+        (InspectorBackendClass.prototype._dispatchEvent):
+        * UserInterface/Protocol/MessageDispatcher.js:
+        (WebInspector.dispatchNextQueuedMessageFromBackend):
+        (WebInspector.dispatchMessageFromBackend): Be consistent about using `this`.
+
 2015-08-25  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js

@@ -1125 +1125 @@
     return new Blob(byteArrays, {type: mimeType});
 }
+
+// FIXME: This can be removed when WEB_TIMING is enabled for all platforms.
+function timestamp()
+{
+    return window.performance ? performance.now() : Date.now();
+}

trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js

@@ -136 +136 @@
         let responseData = {command, callback};
 
-        // FIXME: <https://webkit.org/b/135467> use performance.now() where available.
         if (this.dumpInspectorTimeStats)
-            responseData.sendRequestTime = Date.now();
+            responseData.sendRequestTimestamp = timestamp();
 
         this._pendingResponses.set(sequenceId, responseData);
@@ -158 +157 @@
         let responseData = {command};
 
-        // FIXME: <https://webkit.org/b/135467> use performance.now() where available.
         if (this.dumpInspectorTimeStats)
-            responseData.sendRequestTime = Date.now();
+            responseData.sendRequestTimestamp = timestamp();
 
         let responsePromise = new Promise(function(resolve, reject) {
@@ -196 +194 @@
         let {command, callback, promise} = responseData;
 
-        var processingStartTime;
+        var processingStartTimestamp;
         if (this.dumpInspectorTimeStats)
-            processingStartTime = Date.now();
+            processingStartTimestamp = timestamp();
 
         if (typeof callback === "function")
@@ -207 +205 @@
             console.error("Received a command response without a corresponding callback or promise.", messageObject, command);
 
-        var processingDuration = Date.now() - processingStartTime;
+        let processingDuration = (timestamp() - processingStartTimestamp).toFixed(3);
         if (this.warnForLongMessageHandling && processingDuration > this.longMessageHandlingThreshold)
-            console.warn("InspectorBackend: took " + processingDuration + "ms to handle response for command: " + command.qualifiedName);
-
-        if (this.dumpInspectorTimeStats)
-            console.log("time-stats: Handling: " + processingDuration + "ms; RTT: " + (processingStartTime - responseData.sendRequestTime) + "ms; (command " + command.qualifiedName + ")");
+            console.warn(`InspectorBackend: took ${processingDuration}ms to handle response for command: ${command.qualifiedName}`);
+
+        if (this.dumpInspectorTimeStats) {
+            let roundTripDuration = (processingStartTimestamp - responseData.sendRequestTimestamp).toFixed(3);
+            console.log(`time-stats: Handling: ${processingDuration}ms; RTT: ${roundTripDuration}ms; (command ${command.qualifiedName})`);
+        }
 
         if (this._deferredScripts.length && !this._pendingResponses.size)
@@ -272 +272 @@
         }
 
-        var processingStartTime;
+        var processingStartTimestamp;
         if (this.dumpInspectorTimeStats)
-            processingStartTime = Date.now();
+            processingStartTimestamp = timestamp();
 
         try {
@@ -282 +282 @@
         }
 
-        var processingDuration = Date.now() - processingStartTime;
+        let processingDuration = (timestamp() - processingStartTimestamp).toFixed(3);
         if (this.warnForLongMessageHandling && processingDuration > this.longMessageHandlingThreshold)
-            console.warn("InspectorBackend: took " + processingDuration + "ms to handle event: " + messageObject["method"]);
+            console.warn(`InspectorBackend: took ${processingDuration}ms to handle event: ${messageObject.method}`);
 
         if (this.dumpInspectorTimeStats)
-            console.log("time-stats: Handling: " + processingDuration + "ms (event " + messageObject["method"] + ")");
+            console.log(`time-stats: Handling: ${processingDuration}ms (event ${messageObject.method})`);
     }
 

trunk/Source/WebInspectorUI/UserInterface/Protocol/MessageDispatcher.js

@@ -29 +29 @@
 WebInspector.dispatchNextQueuedMessageFromBackend = function()
 {
-    var startCount = WebInspector._messagesToDispatch.length;
-    var startTime = Date.now();
-    var timeLimitPerRunLoop = 10; // milliseconds
+    const startCount = WebInspector._messagesToDispatch.length;
+    const startTimestamp = timestamp();
+    const timeLimitPerRunLoop = 10; // milliseconds
 
-    var i = 0;
+    let i = 0;
     for (; i < WebInspector._messagesToDispatch.length; ++i) {
         // Defer remaining messages if we have taken too long. In practice, single
         // messages like Page.getResourceContent blow through the time budget.
-        if (Date.now() - startTime > timeLimitPerRunLoop)
+        if (timestamp() - startTimestamp > timeLimitPerRunLoop)
             break;
 
@@ -51 +51 @@
     }
 
-    if (InspectorBackend.dumpInspectorTimeStats)
-        console.log("time-stats: --- RunLoop duration: " + (Date.now() - startTime) + "ms; dispatched: " + (startCount - WebInspector._messagesToDispatch.length) + "; remaining: " + WebInspector._messagesToDispatch.length);
+    if (InspectorBackend.dumpInspectorTimeStats) {
+        let messageDuration = (timestamp() - startTimestamp).toFixed(3);
+        let dispatchedCount = startCount - WebInspector._messagesToDispatch.length;
+        let remainingCount = WebInspector._messagesToDispatch.length;
+        console.log(`time-stats: --- RunLoop duration: ${messageDuration}ms; dispatched: ${dispatchedCount}; remaining: ${remainingCount}`);
+    }
 };
 
@@ -60 +64 @@
     // The messages are dequeued on a zero delay timeout.
 
-    WebInspector._messagesToDispatch.push(message);
+    this._messagesToDispatch.push(message);
 
     if (this._dispatchTimeout)
         return;
 
-    this._dispatchTimeout = setTimeout(WebInspector.dispatchNextQueuedMessageFromBackend, 0);
+    this._dispatchTimeout = setTimeout(this.dispatchNextQueuedMessageFromBackend, 0);
 };