Changeset 18899 in webkit

Timestamp:

Jan 16, 2007 8:37:25 PM (17 years ago)

Author:

aliceli1

Message:

WebCore:

Reviewed by harrison.

Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard

• WebCore.xcodeproj/project.pbxproj:
• bridge/EditorClient.h:
• editing/Editor.cpp: (WebCore::Editor::copy): (WebCore::Editor::didWriteSelectionToPasteboard):
• editing/Editor.h:
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):

WebKit:

Reviewed by harrison.

Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard

• DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:didWriteSelectionToPasteboard:]):
• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::didWriteSelectionToPasteboard):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebEditingDelegate.h:

WebKitQt:

Added these stubs to keep the Qt build from failing.

• WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::didWriteSelectionToPasteboard):
• WebCoreSupport/EditorClientQt.h:

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bridge/EditorClient.h (modified) (1 diff)
• WebCore/editing/Editor.cpp (modified) (2 diffs)
• WebCore/editing/Editor.h (modified) (1 diff)
• WebCore/platform/graphics/svg/SVGImageEmptyClients.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/DefaultDelegates/WebDefaultEditingDelegate.m (modified) (1 diff)
• WebKit/WebCoreSupport/WebEditorClient.h (modified) (1 diff)
• WebKit/WebCoreSupport/WebEditorClient.mm (modified) (1 diff)
• WebKit/WebView/WebEditingDelegate.h (modified) (1 diff)
• WebKitQt/ChangeLog (modified) (1 diff)
• WebKitQt/WebCoreSupport/EditorClientQt.cpp (modified) (1 diff)
• WebKitQt/WebCoreSupport/EditorClientQt.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-01-16  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by harrison.
+
+        Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
+
+        * WebCore.xcodeproj/project.pbxproj:
+        * bridge/EditorClient.h:
+        * editing/Editor.cpp:
+        (WebCore::Editor::copy):
+        (WebCore::Editor::didWriteSelectionToPasteboard):
+        * editing/Editor.h:
+        * platform/graphics/svg/SVGImageEmptyClients.h:
+        (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
+
 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/bridge/EditorClient.h

@@ -75 +75 @@
     virtual void respondToChangedContents() = 0;
     virtual void didEndEditing() = 0;
+    virtual void didWriteSelectionToPasteboard() = 0;
 //  virtual void webViewDidChangeTypingStyle:(NSNotification *)notification = 0;
 //  virtual void webViewDidChangeSelection:(NSNotification *)notification = 0;

trunk/WebCore/editing/Editor.cpp

@@ -1173 +1173 @@
     }
     Pasteboard::generalPasteboard()->writeSelection(selectedRange().get(), canSmartCopyOrDelete(), m_frame);
+    didWriteSelectionToPasteboard();
 }
 
@@ -1292 +1293 @@
 }
 
+void Editor::didWriteSelectionToPasteboard()
+{
+    if (client())
+        client()->didWriteSelectionToPasteboard();
+}
+
 void Editor::toggleBold()
 {

trunk/WebCore/editing/Editor.h

@@ -162 +162 @@
     void didBeginEditing();
     void didEndEditing();
+    void didWriteSelectionToPasteboard();
     
     void showFontPanel();

trunk/WebCore/platform/graphics/svg/SVGImageEmptyClients.h

@@ -298 +298 @@
     virtual void respondToChangedContents() { }
     virtual void didEndEditing() { }
+    virtual void didWriteSelectionToPasteboard() { }
     //  virtual void webViewDidChangeTypingStyle:(NSNotification *)notification { }
     //  virtual void webViewDidChangeSelection:(NSNotification *)notification { }

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-01-16  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by harrison.
+
+        Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
+
+        * DefaultDelegates/WebDefaultEditingDelegate.m:
+        (-[WebDefaultEditingDelegate webView:didWriteSelectionToPasteboard:]):
+        * WebCoreSupport/WebEditorClient.h:
+        * WebCoreSupport/WebEditorClient.mm:
+        (WebEditorClient::didWriteSelectionToPasteboard):
+        * WebKit.xcodeproj/project.pbxproj:
+        * WebView/WebEditingDelegate.h:
+
 2007-01-15  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebKit/DefaultDelegates/WebDefaultEditingDelegate.m

@@ -98 +98 @@
 }
 
+- (void)webView:(WebView *)webView didWriteSelectionToPasteboard:(NSPasteboard *)pasteboard
+{
+}
+
 - (void)webViewDidBeginEditing:(NSNotification *)notification
 {

trunk/WebKit/WebCoreSupport/WebEditorClient.h

@@ -62 +62 @@
     virtual void didBeginEditing();
     virtual void didEndEditing();
+    virtual void didWriteSelectionToPasteboard();
 
     virtual NSData* dataForArchivedSelection(WebCore::Frame*);

trunk/WebKit/WebCoreSupport/WebEditorClient.mm

@@ -241 +241 @@
 {
     [[NSNotificationCenter defaultCenter] postNotificationName:WebViewDidEndEditingNotification object:m_webView];
+}
+
+void WebEditorClient::didWriteSelectionToPasteboard()
+{
+    [[m_webView _editingDelegateForwarder] webView:m_webView didWriteSelectionToPasteboard:[NSPasteboard generalPasteboard]];
 }
 

trunk/WebKit/WebView/WebEditingDelegate.h

@@ -49 +49 @@
 - (BOOL)webView:(WebView *)webView shouldChangeTypingStyle:(DOMCSSStyleDeclaration *)currentStyle toStyle:(DOMCSSStyleDeclaration *)proposedStyle;
 - (BOOL)webView:(WebView *)webView doCommandBySelector:(SEL)selector;
+- (void)webView:(WebView *)webView didWriteSelectionToPasteboard:(NSPasteboard *)pasteboard;
 - (void)webViewDidBeginEditing:(NSNotification *)notification;
 - (void)webViewDidChange:(NSNotification *)notification;

trunk/WebKitQt/ChangeLog

@@ +1 @@
+2007-01-16  Alice Liu  <alice.liu@apple.com>
+
+        Added these stubs to keep the Qt build from failing.
+
+        * WebCoreSupport/EditorClientQt.cpp:
+        (WebCore::EditorClientQt::didWriteSelectionToPasteboard):
+        * WebCoreSupport/EditorClientQt.h:
+
 2007-01-16  Lars Knoll <lars@trolltech.com>
 

trunk/WebKitQt/WebCoreSupport/EditorClientQt.cpp

@@ -118 +118 @@
 }
 
+void EditorClientQt::didWriteSelectionToPasteboard()
+{
+    notImplemented();
+}
+
 bool EditorClientQt::selectWordBeforeMenuEvent()
 {

trunk/WebKitQt/WebCoreSupport/EditorClientQt.h

@@ -62 +62 @@
     virtual void respondToChangedContents();
     virtual void didEndEditing();
+    virtual void didWriteSelectionToPasteboard();
 
     virtual bool selectWordBeforeMenuEvent();