Changeset 189010 in webkit

Timestamp:

Aug 26, 2015 8:32:12 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

[ThreadedCompositor] Use WTF::Condition together with WTF::Lock
​https://bugs.webkit.org/show_bug.cgi?id=148493

Patch by Emanuele Aina <Emanuele Aina> on 2015-08-26
Reviewed by Gyuyoung Kim.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

Replace ThreadCondition::signal() calls with Condition::notifyOne().

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:

Replace ThreadCondition usage with Condition.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (modified) (2 diffs)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-08-26  Emanuele Aina  <emanuele.aina@collabora.com>
+
+        [ThreadedCompositor] Use WTF::Condition together with WTF::Lock
+        https://bugs.webkit.org/show_bug.cgi?id=148493
+
+        Reviewed by Gyuyoung Kim.
+
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+        Replace ThreadCondition::signal() calls with Condition::notifyOne().
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+        Replace ThreadCondition usage with Condition.
+
 2015-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp

@@ -313 +313 @@
         m_viewportController = std::make_unique<SimpleViewportController>(this);
 
-        m_initializeRunLoopCondition.signal();
+        m_initializeRunLoopCondition.notifyOne();
     }
 
@@ -325 +325 @@
         m_compositingRunLoop = nullptr;
         m_context = nullptr;
-        m_terminateRunLoopCondition.signal();
+        m_terminateRunLoopCondition.notifyOne();
     }
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h

@@ -34 +34 @@
 #include <WebCore/IntSize.h>
 #include <WebCore/TransformationMatrix.h>
+#include <wtf/Condition.h>
 #include <wtf/FastMalloc.h>
 #include <wtf/Noncopyable.h>
@@ -111 +112 @@
 
     ThreadIdentifier m_threadIdentifier;
-    ThreadCondition m_initializeRunLoopCondition;
+    Condition m_initializeRunLoopCondition;
     Lock m_initializeRunLoopConditionMutex;
-    ThreadCondition m_terminateRunLoopCondition;
+    Condition m_terminateRunLoopCondition;
     Lock m_terminateRunLoopConditionMutex;
 };