Changeset 189106 in webkit


Ignore:
Timestamp:
Aug 28, 2015 11:13:37 AM (9 years ago)
Author:
commit-queue@webkit.org
Message:

The status message for combined builder queues should say "all builds succeeded" if everything
built correctly.
https://bugs.webkit.org/show_bug.cgi?id=148535

Patch by Jason Marcell <jmarcell@apple.com> on 2015-08-28
Reviewed by David Kilzer and Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:

(BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
say "all builds succeeded" if everything built correctly.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js

    r188838 r189106  
    8888
    8989            var message = this.revisionContentForIteration(slowestQueue.mostRecentSuccessfulIteration);
    90             var status = new StatusLineView(message, StatusLineView.Status.Good, "all tests passed", null, null);
     90            var statusMessagePassed = "all " + (queue.builder ? "builds succeeded" : "tests passed");
     91            var status = new StatusLineView(message, StatusLineView.Status.Good, statusMessagePassed, null, null);
    9192            new PopoverTracker(status.statusBubbleElement, this._presentPopoverForCombinedGreenBubble.bind(this));
    9293            this.element.appendChild(status.element);
  • trunk/Tools/ChangeLog

    r189094 r189106  
     12015-08-28  Jason Marcell  <jmarcell@apple.com>
     2
     3        The status message for combined builder queues should say "all builds succeeded" if everything
     4        built correctly.
     5        https://bugs.webkit.org/show_bug.cgi?id=148535
     6
     7        Reviewed by David Kilzer and Alexey Proskuryakov.
     8
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
     10        (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
     11        say "all builds succeeded" if everything built correctly.
     12
    1132015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
    214
Note: See TracChangeset for help on using the changeset viewer.