Changeset 18913 in webkit


Ignore:
Timestamp:
Jan 17, 2007 1:01:34 PM (17 years ago)
Author:
adele
Message:

LayoutTests:

Reviewed by Anders and John.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11278
<rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

  • fast/forms/menulist-width-change-expected.checksum: Added.
  • fast/forms/menulist-width-change-expected.png: Added.
  • fast/forms/menulist-width-change-expected.txt: Added.
  • fast/forms/menulist-width-change.html: Added.

WebCore:

Reviewed by Anders and John.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11278
<rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

Test: fast/forms/menulist-width-change.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r18912 r18913  
     12007-01-17  Adele Peterson  <adele@apple.com>
     2
     3        Reviewed by Anders and John.
     4
     5        Test for http://bugs.webkit.org/show_bug.cgi?id=11278
     6        <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
     7
     8        * fast/forms/menulist-width-change-expected.checksum: Added.
     9        * fast/forms/menulist-width-change-expected.png: Added.
     10        * fast/forms/menulist-width-change-expected.txt: Added.
     11        * fast/forms/menulist-width-change.html: Added.
     12
    1132007-01-16  Alexey Proskuryakov  <ap@webkit.org>
    214

  • trunk/WebCore/ChangeLog

    r18912 r18913  
     12007-01-17  Adele Peterson  <adele@apple.com>
     2
     3        Reviewed by Anders and John.
     4
     5        Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
     6        <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
     7
     8        Test: fast/forms/menulist-width-change.html
     9
     10        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
     11          When the options change, call setNeedsLayoutAndMinMaxRecalc.
     12
    1132007-01-16  Alexey Proskuryakov  <ap@webkit.org>
    214
    … …  
    15041516        (WebCore::RenderObject::setStyle):
    15051517
    1506 >>>>>>> .r18876
    150715182007-01-13  Lars Knoll <lars@trolltech.com>
    15081519

  • trunk/WebCore/rendering/RenderMenuList.cpp

    r18819 r18913  
    121121        m_optionsWidth = static_cast<int>(ceilf(width));
    122122        m_optionsChanged = false;
     123        setNeedsLayoutAndMinMaxRecalc();
    123124    }
    124125
Note: See TracChangeset for help on using the changeset viewer.