Changeset 189258 in webkit

Timestamp:

Sep 2, 2015 1:03:34 PM (9 years ago)

Author:

Chris Fleizach

Message:

AX: WebKit does not expose max/min value of <progress> element
​https://bugs.webkit.org/show_bug.cgi?id=148707

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Allow native progress indicator elements to report min/max values by rewriting special
case code for ARIA progress bars.

Test: accessibility/mac/progress-element-min-max.html

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

• accessibility/mac/progress-element-min-max-expected.txt: Added.
• accessibility/mac/progress-element-min-max.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/mac/progress-element-min-max-expected.txt (added)
• LayoutTests/accessibility/mac/progress-element-min-max.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-09-02  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: WebKit does not expose max/min value of <progress> element
+        https://bugs.webkit.org/show_bug.cgi?id=148707
+
+        Reviewed by Mario Sanchez Prada.
+
+        * accessibility/mac/progress-element-min-max-expected.txt: Added.
+        * accessibility/mac/progress-element-min-max.html: Added.
+
 2015-09-01  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-09-02  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: WebKit does not expose max/min value of <progress> element
+        https://bugs.webkit.org/show_bug.cgi?id=148707
+
+        Reviewed by Mario Sanchez Prada.
+
+        Allow native progress indicator elements to report min/max values by rewriting special
+        case code for ARIA progress bars.
+
+        Test: accessibility/mac/progress-element-min-max.html
+
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
 2015-09-02  Hyemi Shin  <hyemi.sin@samsung.com>
 

trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

@@ -2572 +2572 @@
     if ([attributeName isEqualToString: NSAccessibilityMinValueAttribute]) {
         // Indeterminate progress indicator should return 0.
-        if (m_object->isProgressIndicator() && !m_object->hasAttribute(aria_valuenowAttr))
+        if (m_object->ariaRoleAttribute() == ProgressIndicatorRole && !m_object->hasAttribute(aria_valuenowAttr))
             return @0;
         return [NSNumber numberWithFloat:m_object->minValueForRange()];
@@ -2579 +2579 @@
     if ([attributeName isEqualToString: NSAccessibilityMaxValueAttribute]) {
         // Indeterminate progress indicator should return 0.
-        if (m_object->isProgressIndicator() && !m_object->hasAttribute(aria_valuenowAttr))
+        if (m_object->ariaRoleAttribute() == ProgressIndicatorRole && !m_object->hasAttribute(aria_valuenowAttr))
             return @0;
         return [NSNumber numberWithFloat:m_object->maxValueForRange()];