Changeset 189331 in webkit

Timestamp:

Sep 3, 2015 7:08:24 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

[Texmap] highp precision should be used conditionally for fragment shaders on OpenGL ES
​https://bugs.webkit.org/show_bug.cgi?id=143993

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-09-03
Reviewed by Martin Robinson.

There are some GPUs that do not support the GL_OES_fragment_precision_high extension. (e.g., Mali-T624)
Therefore, highp precision should be used in shader fragments conditionally using a proper preprocessor,
GL_FRAGMENT_PRECISION_HIGH.
Without this patch, nothing will be displayed on the screen if the running platform doesn't support the
GL_OES_fragment_precision_high extension.

No new tests, covered by existing tests.

• platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/TextureMapperShaderProgram.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-09-03  Jinyoung Hur  <hur.ims@navercorp.com>
+
+        [Texmap] highp precision should be used conditionally for fragment shaders on OpenGL ES
+        https://bugs.webkit.org/show_bug.cgi?id=143993
+
+        Reviewed by Martin Robinson.
+
+        There are some GPUs that do not support the GL_OES_fragment_precision_high extension. (e.g., Mali-T624)
+        Therefore, highp precision should be used in shader fragments conditionally using a proper preprocessor,
+        GL_FRAGMENT_PRECISION_HIGH.
+        Without this patch, nothing will be displayed on the screen if the running platform doesn't support the
+        GL_OES_fragment_precision_high extension.
+
+        No new tests, covered by existing tests.
+
+        * platform/graphics/texmap/TextureMapperShaderProgram.cpp:
+
 2015-09-03  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp

@@ -120 +120 @@
 
 #define GLSL_DIRECTIVE(...) "#"#__VA_ARGS__"\n"
+
+#define TEXTURE_SPACE_MATRIX_PRECISION_DIRECTIVE \
+    GLSL_DIRECTIVE(ifdef GL_FRAGMENT_PRECISION_HIGH) \
+        GLSL_DIRECTIVE(define TextureSpaceMatrixPrecision highp) \
+    GLSL_DIRECTIVE(else) \
+        GLSL_DIRECTIVE(define TextureSpaceMatrixPrecision mediump) \
+    GLSL_DIRECTIVE(endif)
+
 static const char* vertexTemplate =
+    TEXTURE_SPACE_MATRIX_PRECISION_DIRECTIVE
     STRINGIFY(
+        precision TextureSpaceMatrixPrecision float;
         attribute vec4 a_vertex;
         uniform mat4 u_modelViewMatrix;
@@ -208 +218 @@
     ANTIALIASING_TEX_COORD_DIRECTIVE
     BLUR_CONSTANTS
+    TEXTURE_SPACE_MATRIX_PRECISION_DIRECTIVE
     STRINGIFY(
-        precision highp float;
+        precision TextureSpaceMatrixPrecision float;
         uniform mat4 u_textureSpaceMatrix;
         precision mediump float;