Changeset 189595 in webkit

Timestamp:

Sep 10, 2015 3:59:08 PM (9 years ago)

Author:

ap@apple.com

Message:

Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
​https://bugs.webkit.org/show_bug.cgi?id=142929

Reviewed by Brent Fulgham.

Tools:

Silence the logging. We'll track fixing the root cause in Radar.

• Scripts/webkitpy/port/mac.py:

(MacPort.stderr_patterns_to_strip): Added a FIXME.

• Scripts/webkitpy/port/win.py:

(WinPort.logging_patterns_to_strip): Added.

LayoutTests:

• platform/win/TestExpectations: Unskip some newly added tests that are affected.

We still skip the whole media directory - updating the results and unskipping those
tests would be a separate project.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/TestExpectations (modified) (3 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/port/mac.py (modified) (1 diff)
• Tools/Scripts/webkitpy/port/win.py (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-09-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+        https://bugs.webkit.org/show_bug.cgi?id=142929
+
+        Reviewed by Brent Fulgham.
+
+        * platform/win/TestExpectations: Unskip some newly added tests that are affected.
+        We still skip the whole media directory - updating the results and unskipping those
+        tests would be a separate project.
+
 2015-09-10  David Hyatt  <hyatt@apple.com>
 

trunk/LayoutTests/platform/win/TestExpectations

@@ -727 +727 @@
 # Sensitive to load timing or PHP behavior
 webkit.org/b/44873 http/tests/css/css-image-loading.html [ Skip ]
-webkit.org/b/149007 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html [ Pass Failure ]
-http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html [ Pass Failure ] # Flaky
 
 # Assertion failure in replaySavedEvents http://webkit.org/b/21796
@@ -753 +751 @@
 # Deactivate all media tests on Apple Windows due to <rdar://problem/18681688> generating 
 # spam logging output that causes tests to fail. Will re-enable once this is fixed. 
+# FIXME: We now filter out the logging, so many of the tests can likely be re-enabled.
 media [ Skip ] 
 fast/media [ Skip ] 
@@ -758 +757 @@
 
 fast/layers/video-layer.html [ Skip ] # Skip until video control changes are done.
-
-# "AQMEIOManager::FindIOUnit: error -1" errors in tests output.
-webkit.org/b/148903 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ [ Skip ]
 
 # Assertion failures

trunk/Tools/ChangeLog

@@ +1 @@
+2015-09-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+        https://bugs.webkit.org/show_bug.cgi?id=142929
+
+        Reviewed by Brent Fulgham.
+
+        Silence the logging. We'll track fixing the root cause in Radar.
+
+        * Scripts/webkitpy/port/mac.py:
+        (MacPort.stderr_patterns_to_strip): Added a FIXME.
+
+        * Scripts/webkitpy/port/win.py:
+        (WinPort.logging_patterns_to_strip): Added.
+
 2015-09-09  Andy Estes  <aestes@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/mac.py

@@ -313 +313 @@
     def stderr_patterns_to_strip(self):
         worthless_patterns = []
+        # FIXME: We still get CoreMedia stderr logging that doesn't match the below lines. 'defaults write com.apple.coremedia fig_notes 0' may work better for silencing them all, however running tests shouldn't change user's defaults.
         worthless_patterns.append((re.compile('.*(Fig|fig|itemasync|vt|mv_|PullParamSetSPS|ccrp_|client).* signalled err=.*\n'), ''))
         worthless_patterns.append((re.compile('.*<<<< FigFilePlayer >>>>.*\n'), ''))

trunk/Tools/Scripts/webkitpy/port/win.py

@@ -329 +329 @@
 
         return system_pid
+
+    def logging_patterns_to_strip(self):
+        # rdar://problem/18681688
+        return [(re.compile('AQMEIOManager::FindIOUnit: error \-1\n'), '')]