Changeset 189702 in webkit

Timestamp:

Sep 14, 2015 2:46:37 AM (9 years ago)

Author:

Manuel Rego Casasnovas

Message:

[css-grid] Percentage columns should remove scrollbar's width
​https://bugs.webkit.org/show_bug.cgi?id=149116

Reviewed by Sergio Villar Senin.

Source/WebCore:

Currently the calculation of percentage columns was not subtracting the
scrollbar's size.
Fixed RenderGrid::computeUsedBreadthOfSpecifiedLength()
to avoid this problem.

Test: fast/css-grid-layout/grid-percent-track-scrollbar.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

LayoutTests:

Added test to check the behavior for both columns and rows.
Note that rows (height) were already working fine.

• fast/css-grid-layout/grid-percent-track-scrollbar-expected.txt: Added.
• fast/css-grid-layout/grid-percent-track-scrollbar.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css-grid-layout/grid-percent-track-scrollbar-expected.txt (added)
• LayoutTests/fast/css-grid-layout/grid-percent-track-scrollbar.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderGrid.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-09-14  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Percentage columns should remove scrollbar's width
+        https://bugs.webkit.org/show_bug.cgi?id=149116
+
+        Reviewed by Sergio Villar Senin.
+
+        Added test to check the behavior for both columns and rows.
+        Note that rows (height) were already working fine.
+
+        * fast/css-grid-layout/grid-percent-track-scrollbar-expected.txt: Added.
+        * fast/css-grid-layout/grid-percent-track-scrollbar.html: Added.
+
 2015-09-14  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-09-14  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Percentage columns should remove scrollbar's width
+        https://bugs.webkit.org/show_bug.cgi?id=149116
+
+        Reviewed by Sergio Villar Senin.
+
+        Currently the calculation of percentage columns was not subtracting the
+        scrollbar's size.
+        Fixed RenderGrid::computeUsedBreadthOfSpecifiedLength()
+        to avoid this problem.
+
+        Test: fast/css-grid-layout/grid-percent-track-scrollbar.html
+
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):
+
 2015-09-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderGrid.cpp

@@ -452 +452 @@
     ASSERT(trackLength.isSpecified());
     if (direction == ForColumns)
-        return valueForLength(trackLength, logicalWidth() - borderAndPaddingLogicalWidth());
+        return valueForLength(trackLength, contentLogicalWidth());
     return valueForLength(trackLength, computeContentLogicalHeight(MainOrPreferredSize, style().logicalHeight(), Nullopt).valueOr(0));
 }