Changeset 189909 in webkit

Timestamp:

Sep 17, 2015 12:28:52 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out
​https://bugs.webkit.org/show_bug.cgi?id=149197

Patch by Devin Rousso <Devin Rousso> on 2015-09-17
Reviewed by Timothy Hatcher.

In r188427, logic was added to preserve the leading whitespace of styles in a CSS file.
An unfortunate side effect of this was that extra newlines in between CSS properties
were treated as valid and left where they were. This is undesired behaviour and often
clutters the styles sidebar. These changes remove the extra newlines.

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContent):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDeclarationTextEditor.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-09-17  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out
+        https://bugs.webkit.org/show_bug.cgi?id=149197
+
+        Reviewed by Timothy Hatcher.
+
+        In r188427, logic was added to preserve the leading whitespace of styles in a CSS file.
+        An unfortunate side effect of this was that extra newlines in between CSS properties
+        were treated as valid and left where they were.  This is undesired behaviour and often
+        clutters the styles sidebar.  These changes remove the extra newlines.
+
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContent):
+
 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js

@@ -727 +727 @@
         content += this._suffixWhitespace;
 
-        return content;
+        // This regular expression replacement removes extra newlines
+        // in between properties while preserving leading whitespace
+        return content.replace(/\s*\n\s*\n(\s*)/g, "\n$1");
     }