Changeset 189923 in webkit

Timestamp:

Sep 17, 2015 12:28:33 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
​https://bugs.webkit.org/show_bug.cgi?id=149274

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-17
Reviewed by Brian Burg.

The dashboard container gets an opacity when the window is inactive. Combined
with the animating debugger continue button this caused a cascade of slightly
overlapping content causing a cascade of a lot of small layers. The simple
approach taken here is to stop the slight pulse animation when the window
is inactive.

• UserInterface/Views/DebuggerDashboardView.css:

(body.window-inactive .dashboard.debugger .navigation-bar .item.button > .glyph):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DebuggerDashboardView.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
+        https://bugs.webkit.org/show_bug.cgi?id=149274
+
+        Reviewed by Brian Burg.
+
+        The dashboard container gets an opacity when the window is inactive. Combined
+        with the animating debugger continue button this caused a cascade of slightly
+        overlapping content causing a cascade of a lot of small layers. The simple
+        approach taken here is to stop the slight pulse animation when the window
+        is inactive.
+
+        * UserInterface/Views/DebuggerDashboardView.css:
+        (body.window-inactive .dashboard.debugger .navigation-bar .item.button > .glyph):
+
 2015-09-17  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css

@@ -65 +65 @@
     animation-direction: alternate;
     background-color: hsl(207, 46%, 59%) !important;
+}
+
+body.window-inactive .dashboard.debugger .navigation-bar .item.button > .glyph {
+    animation-name: none;
 }