Context Navigation

← Previous Changeset
Next Changeset →

Changeset 189947 in webkit

Timestamp:

Sep 17, 2015 5:16:09 PM (9 years ago)

Author:

Alan Bujtas

Message:

CSS WG multicol-1 tests failures with 1px differences due to baseline difference.
https://bugs.webkit.org/show_bug.cgi?id=149245

Reviewed by Ryosuke Niwa.

Turn off font-aliasing for multicol tests where the reference tests' inline content
end up on a different baseline (fractional difference). (It's not considered a bug, they don't
necessarily match.)

LayoutTests/imported/w3c:

css/css-multicol-1/multicol-basic-001-expected.html:
css/css-multicol-1/multicol-basic-001.html:
css/css-multicol-1/multicol-basic-002-expected.html:
css/css-multicol-1/multicol-basic-002.html:
css/css-multicol-1/multicol-basic-003-expected.html:
css/css-multicol-1/multicol-basic-003.html:
css/css-multicol-1/multicol-basic-004-expected.html:
css/css-multicol-1/multicol-basic-004.html:
css/css-multicol-1/multicol-rule-002-expected.xht:
css/css-multicol-1/multicol-rule-002.xht:
css/css-multicol-1/multicol-rule-px-001-expected.xht:
css/css-multicol-1/multicol-rule-px-001.xht:
css/css-multicol-1/multicol-rule-stacking-001-expected.xht:
css/css-multicol-1/multicol-rule-stacking-001.xht:
css/css-multicol-1/multicol-shorthand-001-expected.xht:
css/css-multicol-1/multicol-shorthand-001.xht:
css/css-multicol-1/multicol-span-all-block-sibling-003-expected.xht:
css/css-multicol-1/multicol-span-all-block-sibling-003.xht:
css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001-expected.xht:
css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht:

LayoutTests:

TestExpectations:

Location:

trunk/LayoutTests

Files:

: 23 edited

ChangeLog (modified) (1 diff)
TestExpectations (modified) (1 diff)
imported/w3c/ChangeLog (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-001-expected.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-001.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-002-expected.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-002.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-003-expected.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-003.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-004-expected.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-basic-004.html (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-rule-002-expected.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-rule-002.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-rule-px-001-expected.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-rule-px-001.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-rule-stacking-001-expected.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-rule-stacking-001.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-shorthand-001-expected.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-shorthand-001.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-span-all-block-sibling-003-expected.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-span-all-block-sibling-003.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001-expected.xht (modified) (1 diff)
imported/w3c/css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/LayoutTests/ChangeLog

-                      r189938
+                      r189947
+-09-17  Zalan Bujtas  <zalan@apple.com>
+        CSS WG multicol-1 tests failures with 1px differences due to baseline difference.
+        https://bugs.webkit.org/show_bug.cgi?id=149245
+        Reviewed by Ryosuke Niwa.
+        Turn off font-aliasing for multicol tests where the reference tests' inline content
+        end up on a different baseline (fractional difference). (It's not considered a bug, they don't
+        necessarily match.)
+        * TestExpectations:
 -09-17  Saam barati  <sbarati@apple.com>

trunk/LayoutTests/TestExpectations

-                      r189916
+                      r189947
 # Many CSS WG multicol-1 tests fail with 1px differences
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-basic-001.html [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-basic-002.html [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-basic-003.html [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-basic-004.html [ ImageOnlyFailure ]
 webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-count-large-001.xht [ ImageOnlyFailure ]
 webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-count-large-002.xht [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-rule-002.xht [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-rule-px-001.xht [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-rule-stacking-001.xht [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-shorthand-001.xht [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-span-all-block-sibling-003.xht [ ImageOnlyFailure ]
 webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-rule-fraction-003.xht [ ImageOnlyFailure ]
-webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht [ ImageOnlyFailure ]
 webkit.org/b/148806 imported/w3c/css/css-multicol-1/multicol-count-computed-002.xht [ ImageOnlyFailure ]

trunk/LayoutTests/imported/w3c/ChangeLog

-                      r189914
+                      r189947
+-09-17  Zalan Bujtas  <zalan@apple.com>
+        CSS WG multicol-1 tests failures with 1px differences due to baseline difference.
+        https://bugs.webkit.org/show_bug.cgi?id=149245
+        Reviewed by Ryosuke Niwa.
+        Turn off font-aliasing for multicol tests where the reference tests' inline content
+        end up on a different baseline (fractional difference). (It's not considered a bug, they don't
+        necessarily match.)
+        * css/css-multicol-1/multicol-basic-001-expected.html:
+        * css/css-multicol-1/multicol-basic-001.html:
+        * css/css-multicol-1/multicol-basic-002-expected.html:
+        * css/css-multicol-1/multicol-basic-002.html:
+        * css/css-multicol-1/multicol-basic-003-expected.html:
+        * css/css-multicol-1/multicol-basic-003.html:
+        * css/css-multicol-1/multicol-basic-004-expected.html:
+        * css/css-multicol-1/multicol-basic-004.html:
+        * css/css-multicol-1/multicol-rule-002-expected.xht:
+        * css/css-multicol-1/multicol-rule-002.xht:
+        * css/css-multicol-1/multicol-rule-px-001-expected.xht:
+        * css/css-multicol-1/multicol-rule-px-001.xht:
+        * css/css-multicol-1/multicol-rule-stacking-001-expected.xht:
+        * css/css-multicol-1/multicol-rule-stacking-001.xht:
+        * css/css-multicol-1/multicol-shorthand-001-expected.xht:
+        * css/css-multicol-1/multicol-shorthand-001.xht:
+        * css/css-multicol-1/multicol-span-all-block-sibling-003-expected.xht:
+        * css/css-multicol-1/multicol-span-all-block-sibling-003.xht:
+        * css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001-expected.xht:
+        * css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht:
 -09-17  Chris Dumez  <cdumez@apple.com>

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-001-expected.html

r189364	r189947
11	11	.multicol-wrapper>*{
12	12	font-family: Ahem;
	13	-webkit-font-smoothing: none;
13	14	}
14	15

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-001.html

r189364	r189947
14	14	.multicol-wrapper>*{
15	15	font-family: Ahem;
	16	-webkit-font-smoothing: none;
16	17	}
17	18

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-002-expected.html

r189364	r189947
11	11	.multicol-wrapper>*{
12	12	font-family: Ahem;
	13	-webkit-font-smoothing: none;
13	14	}
14	15

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-002.html

r189364	r189947
14	14	.multicol-wrapper>*{
15	15	font-family: Ahem;
	16	-webkit-font-smoothing: none;
16	17	}
17	18

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-003-expected.html

r189364	r189947
11	11	.multicol-wrapper>*{
12	12	font-family: Ahem;
	13	-webkit-font-smoothing: none;
13	14	}
14	15

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-003.html

r189364	r189947
14	14	.multicol-wrapper>*{
15	15	font-family: Ahem;
	16	-webkit-font-smoothing: none;
16	17	}
17	18

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-004-expected.html

r189364	r189947
11	11	.multicol-wrapper>*{
12	12	font-family: Ahem;
	13	-webkit-font-smoothing: none;
13	14	}
14	15

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-basic-004.html

r189364	r189947
14	14	.multicol-wrapper>*{
15	15	font-family: Ahem;
	16	-webkit-font-smoothing: none;
16	17	}
17	18

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-rule-002-expected.xht

r189364	r189947
12	12	font-family: ahem;
13	13	font-size: 1em;
	14	-webkit-font-smoothing: none;
14	15	line-height: 1em;
15	16	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-rule-002.xht

r189364	r189947
15	15	font-family: ahem;
16	16	font-size: 1em;
	17	-webkit-font-smoothing: none;
17	18	line-height: 1em;
18	19	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-rule-px-001-expected.xht

r189364	r189947
12	12	font-family: ahem;
13	13	font-size: 1em;
	14	-webkit-font-smoothing: none;
14	15	line-height: 1em;
15	16	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-rule-px-001.xht

r189364	r189947
15	15	font-family: ahem;
16	16	font-size: 1em;
	17	-webkit-font-smoothing: none;
17	18	line-height: 1em;
18	19	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-rule-stacking-001-expected.xht

r189364	r189947
12	12	font-family: ahem;
13	13	font-size: 1em;
	14	-webkit-font-smoothing: none;
14	15	line-height: 1em;
15	16	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-rule-stacking-001.xht

r189364	r189947
15	15	font-family: ahem;
16	16	font-size: 1em;
	17	-webkit-font-smoothing: none;
17	18	line-height: 1em;
18	19	color: blue;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-shorthand-001-expected.xht

r189364	r189947
12	12	font-family: ahem;
13	13	font-size: 1em;
	14	-webkit-font-smoothing: none;
14	15	line-height: 1em;
15	16	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-shorthand-001.xht

r189364	r189947
15	15	font-family: ahem;
16	16	font-size: 1em;
	17	-webkit-font-smoothing: none;
17	18	line-height: 1em;
18	19	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-span-all-block-sibling-003-expected.xht

r189364	r189947
9	9	font-family: ahem;
10	10	font-size: 1em;
	11	-webkit-font-smoothing: none;
11	12	line-height: 1;
12	13	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-span-all-block-sibling-003.xht

r189364	r189947
12	12	font-family: ahem;
13	13	font-size: 1em;
	14	-webkit-font-smoothing: none;
14	15	line-height: 1;
15	16	color: black;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001-expected.xht

r189364	r189947
12	12	font-family: ahem;
13	13	font-size: 1em;
	14	-webkit-font-smoothing: none;
14	15	line-height: 1em;
15	16	color: navy;

trunk/LayoutTests/imported/w3c/css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht

r189364	r189947
15	15	font-family: ahem;
16	16	font-size: 1em;
	17	-webkit-font-smoothing: none;
17	18	line-height: 1em;
18	19	color: navy;

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 189947 in webkit

Legend:

Download in other formats: