Changeset 189994 in webkit


Ignore:
Timestamp:
Sep 18, 2015 4:19:46 PM (9 years ago)
Author:
n_wang@apple.com
Message:

AX: Implement ARIA 1.1 @aria-current on iOS
​https://bugs.webkit.org/show_bug.cgi?id=149297

Reviewed by Chris Fleizach.

Source/WebCore:

Added support for iOS to query for aria-current status.
Also, enabled aria-current.html test on iOS.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityInvalidStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIACurrentStatus]):
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):

Tools:

Added support to test aria-current on iOS.

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::stringAttributeValue):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

  • platform/ios-simulator/TestExpectations:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r189989 r189994  
     12015-09-18  Nan Wang  <n_wang@apple.com>
     2
     3        AX: Implement ARIA 1.1 @aria-current on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=149297
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * platform/ios-simulator/TestExpectations:
     9
    1102015-09-18  Jake Nielsen  <jacob_nielsen@apple.com>
    211

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r189983 r189994  
    28322832css3/line-break-language-sensitive/line-break-loose-sound-marks.html [ ImageOnlyFailure Pass ]
    28332833css3/line-break-language-sensitive/line-break-normal-sound-marks.html [ ImageOnlyFailure Pass ]
     2834
     2835# Enable "aria-current" test for iOS
     2836webkit.org/b/149297 accessibility/aria-current.html [ Pass ]

  • trunk/Source/WebCore/ChangeLog

    r189991 r189994  
     12015-09-18  Nan Wang  <n_wang@apple.com>
     2
     3        AX: Implement ARIA 1.1 @aria-current on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=149297
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Added support for iOS to query for aria-current status.
     9        Also, enabled aria-current.html test on iOS.
     10
     11        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     12        (-[WebAccessibilityObjectWrapper accessibilityInvalidStatus]):
     13        (-[WebAccessibilityObjectWrapper accessibilityARIACurrentStatus]):
     14        (-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
     15
    1162015-09-18  Alex Christensen  <achristensen@webkit.org>
    217

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r189650 r189994  
    24122412}
    24132413
     2414- (NSString *)accessibilityARIACurrentStatus
     2415{
     2416    if (![self _prepareAccessibilityCall])
     2417        return nil;
     2418   
     2419    switch (m_object->ariaCurrentState()) {
     2420    case ARIACurrentFalse:
     2421        return @"false";
     2422    case ARIACurrentPage:
     2423        return @"page";
     2424    case ARIACurrentStep:
     2425        return @"step";
     2426    case ARIACurrentLocation:
     2427        return @"location";
     2428    case ARIACurrentTime:
     2429        return @"time";
     2430    case ARIACurrentDate:
     2431        return @"date";
     2432    default:
     2433    case ARIACurrentTrue:
     2434        return @"true";
     2435    }
     2436}
     2437
    24142438- (WebAccessibilityObjectWrapper *)accessibilityMathRootIndexObject
    24152439{

  • trunk/Tools/ChangeLog

    r189981 r189994  
     12015-09-18  Nan Wang  <n_wang@apple.com>
     2
     3        AX: Implement ARIA 1.1 @aria-current on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=149297
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Added support to test aria-current on iOS.
     9
     10        * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
     11        (AccessibilityUIElement::stringAttributeValue):
     12        * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
     13        (WTR::AccessibilityUIElement::stringAttributeValue):
     14
    1152015-09-18  Alexey Proskuryakov  <ap@apple.com>
    216

  • trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm

    r189149 r189994  
    8484- (void)_accessibilityActivate;
    8585- (UIAccessibilityTraits)_axSelectedTrait;
     86- (NSString *)accessibilityARIACurrentStatus;
    8687@end
    8788
    … …  
    410411        return [[m_element accessibilityPlaceholderValue] createJSStringRef];
    411412   
     413    if (JSStringIsEqualToUTF8CString(attribute, "AXARIACurrent"))
     414        return [[m_element accessibilityARIACurrentStatus] createJSStringRef];
     415   
    412416    return JSStringCreateWithCharacters(0, 0);
    413417}

  • trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

    r189149 r189994  
    6161- (void)_accessibilityActivate;
    6262- (UIAccessibilityTraits)_axSelectedTrait;
     63- (NSString *)accessibilityARIACurrentStatus;
    6364@end
    6465
    … …  
    314315    if (JSStringIsEqualToUTF8CString(attribute, "AXPlaceholderValue"))
    315316        return [[m_element accessibilityPlaceholderValue] createJSStringRef];
     317   
     318    if (JSStringIsEqualToUTF8CString(attribute, "AXARIACurrent"))
     319        return [[m_element accessibilityARIACurrentStatus] createJSStringRef];
    316320   
    317321    return JSStringCreateWithCharacters(0, 0);
Note: See TracChangeset for help on using the changeset viewer.