Changeset 190046 in webkit


Ignore:
Timestamp:
Sep 21, 2015 12:28:12 AM (9 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK] run-gtk-tests doesn't provide feedback about crashing google tests
https://bugs.webkit.org/show_bug.cgi?id=149252

Reviewed by Darin Adler.

In case of glib tests the test runner notifies about tests
crashing, but for google tests we don't get any feedback, which
means that in case of a test crashing we get a list of PASS
messages and at the summary we are notified that the test suite
has failed, but it's impossible to know which test cases have failed.

  • Scripts/run-gtk-tests:

(TestRunner._run_google_test): Add a CRASH message if test
case crashed.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r190035 r190046  
     12015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
     4        https://bugs.webkit.org/show_bug.cgi?id=149252
     5
     6        Reviewed by Darin Adler.
     7
     8        In case of glib tests the test runner notifies about tests
     9        crashing, but for google tests we don't get any feedback, which
     10        means that in case of a test crashing we get a list of **PASS**
     11        messages and at the summary we are notified that the test suite
     12        has failed, but it's impossible to know which test cases have failed.
     13
     14        * Scripts/run-gtk-tests:
     15        (TestRunner._run_google_test): Add a **CRASH** message if test
     16        case crashed.
     17
    1182015-09-20  Alexey Proskuryakov  <ap@apple.com>
    219
  • trunk/Tools/Scripts/run-gtk-tests

    r189021 r190046  
    349349        if subtest in TestRunner.SLOW:
    350350            timeout *= 5
    351         return self._run_test_command(test_command, timeout)
     351
     352        status = self._run_test_command(test_command, timeout)
     353        if status == -SIGSEGV:
     354            sys.stdout.write("**CRASH** %s\n" % subtest)
     355            sys.stdout.flush()
     356        return status
    352357
    353358    def _run_google_test_suite(self, test_program):
Note: See TracChangeset for help on using the changeset viewer.