Changeset 190285 in webkit

Timestamp:

Sep 28, 2015 2:44:26 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
​https://bugs.webkit.org/show_bug.cgi?id=149223

Patch by João Oliveira <​hello@jxs.pt> on 2015-09-28
Reviewed by Timothy Hatcher.

When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
if so text is selected, if the textbox is empty, textbox gains focus.

• UserInterface/Views/SearchBar.js:

(WebInspector.SearchBar.prototype.focus):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SearchBar.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-09-28  João Oliveira  <hello@jxs.pt>
+
+        Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
+        https://bugs.webkit.org/show_bug.cgi?id=149223
+
+        Reviewed by Timothy Hatcher.
+
+        When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
+        if so text is selected, if the textbox is empty, textbox gains focus.
+
+        * UserInterface/Views/SearchBar.js:
+        (WebInspector.SearchBar.prototype.focus):
+
 2015-09-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SearchBar.js

@@ -62 +62 @@
     focus()
     {
-        this._searchInput.focus();
-        this._searchInput.select();
+        // FIXME: Workaround for: <https://webkit.org/b/149504> Caret missing from <input> after clearing text and calling select()
+        if (!this._searchInput.value.length)
+            this._searchInput.focus();
+        else
+            this._searchInput.select();
     }