Changeset 190340 in webkit

Timestamp:

Sep 29, 2015 10:55:44 PM (9 years ago)

Author:

rniwa@webkit.org

Message:

ASSERTION FAILED: !isUnreachableNode(m_target.get()) when hovering over any input element
​https://bugs.webkit.org/show_bug.cgi?id=149589

Reviewed by Darin Adler.

The bug was caused by target not being reset across shadow boundary when SHADOW_DOM was disabled.

No new tests since exiting tests cover this in debug builds. e.g. editing/deleting/5290534.html

• dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/EventDispatcher.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-09-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        ASSERTION FAILED: !isUnreachableNode(m_target.get()) when hovering over any input element
+        https://bugs.webkit.org/show_bug.cgi?id=149589
+
+        Reviewed by Darin Adler.
+
+        The bug was caused by target not being reset across shadow boundary when SHADOW_DOM was disabled.
+
+        No new tests since exiting tests cover this in debug builds. e.g. editing/deleting/5290534.html
+
+        * dom/EventDispatcher.cpp:
+        (WebCore::EventPath::EventPath):
+
 2015-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/Source/WebCore/dom/EventDispatcher.cpp

@@ -456 +456 @@
             ASSERT(shadowRoot.host()->contains(target->toNode()));
         } else
+#endif
             target = nullptr;
-#endif
+
         if (!shouldEventCrossShadowBoundary(event, shadowRoot, originalTarget))
             return;