Changeset 190579 in webkit


Ignore:
Timestamp:
Oct 5, 2015 2:21:18 PM (9 years ago)
Author:
commit-queue@webkit.org
Message:

Cleaning up after revision 190339
​https://bugs.webkit.org/show_bug.cgi?id=149732

Patch by Jiewen Tan <​jiewen_tan@apple.com> on 2015-10-05
Reviewed by Myles C. Maxfield.

Source/WebCore:

  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::compileStyleSheet):

LayoutTests:

  • svg/custom/invalid-xslt-crash.svg:
  • svg/custom/invalid-xslt-crash-expected.txt:

Replace render tree dump test with text dump.
Pass if no crash.

Location:
trunk
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r190577 r190579  
     12015-10-05  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Cleaning up after revision 190339
     4        https://bugs.webkit.org/show_bug.cgi?id=149732
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        * svg/custom/invalid-xslt-crash.svg:
     9        * svg/custom/invalid-xslt-crash-expected.txt:
     10        Replace render tree dump test with text dump.
     11        Pass if no crash.
     12
    1132015-10-05  Timothy Horton  <timothy_horton@apple.com>
    214

  • trunk/LayoutTests/svg/custom/invalid-xslt-crash.svg

    r190339 r190579  
    33                xmlns:xslt="http://www.w3.org/1999/XSL/Transform"
    44                xslt:version="1.0">
    5   <!-- The test passes if it doesn't crash -->
    6   <xslt:attribute nnnnnnnnnnname="fill">lime</xslt:attribute>
     5    <script>
     6        if (window.testRunner)
     7            testRunner.dumpAsText();
     8    </script>
     9
     10    <!-- The test passes if it doesn't crash -->
     11    <xslt:attribute nnnnnnnnnnname="fill">lime</xslt:attribute>
    712</svg>

  • trunk/Source/WebCore/ChangeLog

    r190576 r190579  
     12015-10-05  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Cleaning up after revision 190339
     4        https://bugs.webkit.org/show_bug.cgi?id=149732
     5
     6        Reviewed by Myles C. Maxfield.
     7
     8        * xml/XSLStyleSheet.h:
     9        * xml/XSLStyleSheetLibxslt.cpp:
     10        (WebCore::XSLStyleSheet::compileStyleSheet):
     11
    1122015-10-05  Beth Dakin  <bdakin@apple.com>
    213

  • trunk/Source/WebCore/xml/XSLStyleSheet.h

    r190339 r190579  
    117117    xmlDocPtr m_stylesheetDoc;
    118118    bool m_stylesheetDocTaken;
    119     bool m_compilationFailed = false;
     119    bool m_compilationFailed { false };
    120120
    121121    XSLStyleSheet* m_parentStyleSheet;

  • trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp

    r190339 r190579  
    249249    // failures - hence attempting to recompile after a failure is unsafe.
    250250    if (m_compilationFailed)
    251         return 0;
     251        return nullptr;
    252252
    253253    // xsltParseStylesheetDoc makes the document part of the stylesheet
Note: See TracChangeset for help on using the changeset viewer.