Changeset 190728 in webkit

Timestamp:

Oct 8, 2015 9:26:40 AM (9 years ago)

Author:

Antti Koivisto

Message:

CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
​https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/use-window-inactive-crash.html

• css/SelectorCheckerTestFunctions.h:

(WebCore::isWindowInactive):

Null check page.

LayoutTests:

The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.

• svg/css/use-window-inactive-crash-expected.html: Added.
• svg/css/use-window-inactive-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/css/use-window-inactive-crash-expected.html (added)
• LayoutTests/svg/css/use-window-inactive-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/SelectorCheckerTestFunctions.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-10-08  Antti Koivisto  <antti@apple.com>
+
+        CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
+        https://bugs.webkit.org/show_bug.cgi?id=149921
+        rdar://problem/22731359
+
+        Reviewed by Andreas Kling.
+
+        The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
+        it for coverage.
+
+        * svg/css/use-window-inactive-crash-expected.html: Added.
+        * svg/css/use-window-inactive-crash.html: Added.
+
 2015-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-10-08  Antti Koivisto  <antti@apple.com>
+
+        CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
+        https://bugs.webkit.org/show_bug.cgi?id=149921
+        rdar://problem/22731359
+
+        Reviewed by Andreas Kling.
+
+        Test: svg/css/use-window-inactive-crash.html
+
+        * css/SelectorCheckerTestFunctions.h:
+        (WebCore::isWindowInactive):
+
+            Null check page.
+
 2015-10-08  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h

@@ -118 +118 @@
 ALWAYS_INLINE bool isWindowInactive(const Element* element)
 {
-    return !element->document().page()->focusController().isActive();
+    auto* page = element->document().page();
+    if (!page)
+        return false;
+    return !page->focusController().isActive();
 }