Changeset 190829 in webkit
- Timestamp:
- Oct 9, 2015 4:17:59 PM (8 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r190827 r190829 1 2015-10-09 Joseph Pecoraro <pecoraro@apple.com> 2 3 No need to keep setting needsVisit flag in SmallStrings 4 https://bugs.webkit.org/show_bug.cgi?id=149961 5 6 Reviewed by Andreas Kling. 7 8 SmallStrings are all initialized at once privately before the VM 9 enables Garbage Collection. There is no need to keep updating 10 this flag, as it couldn't have changed. 11 12 * runtime/SmallStrings.cpp: 13 (JSC::SmallStrings::createEmptyString): 14 (JSC::SmallStrings::createSingleCharacterString): 15 (JSC::SmallStrings::initialize): 16 * runtime/SmallStrings.h: 17 1 18 2015-10-09 Geoffrey Garen <ggaren@apple.com> 2 19 -
trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp
r184612 r190829 110 110 ASSERT(!m_emptyString); 111 111 m_emptyString = JSString::createHasOtherOwner(*vm, StringImpl::empty()); 112 m_needsToBeVisited = true;112 ASSERT(m_needsToBeVisited); 113 113 } 114 114 … … 119 119 ASSERT(!m_singleCharacterStrings[character]); 120 120 m_singleCharacterStrings[character] = JSString::createHasOtherOwner(*vm, PassRefPtr<StringImpl>(m_storage->rep(character))); 121 m_needsToBeVisited = true;121 ASSERT(m_needsToBeVisited); 122 122 } 123 123 … … 132 132 { 133 133 string = JSString::create(*vm, Identifier::fromString(vm, value).impl()); 134 m_needsToBeVisited = true;134 ASSERT(m_needsToBeVisited); 135 135 } 136 136 -
trunk/Source/JavaScriptCore/runtime/SmallStrings.h
r183724 r190829 49 49 namespace JSC { 50 50 51 class HeapRootVisitor;52 51 class VM; 53 52 class JSString; … … 124 123 static const unsigned singleCharacterStringCount = maxSingleCharacterString + 1; 125 124 126 JS_EXPORT_PRIVATEvoid createEmptyString(VM*);127 JS_EXPORT_PRIVATEvoid createSingleCharacterString(VM*, unsigned char);125 void createEmptyString(VM*); 126 void createSingleCharacterString(VM*, unsigned char); 128 127 129 128 void initialize(VM*, JSString*&, const char* value);
Note: See TracChangeset
for help on using the changeset viewer.