Changeset 190843 in webkit

Timestamp:

Oct 10, 2015 2:14:56 PM (9 years ago)

Author:

akling@apple.com

Message:

Reduce pointless malloc traffic in CodeBlock construction.
<​https://webkit.org/b/149999>

Reviewed by Antti Koivisto.

Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):

• bytecode/CodeBlock.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/CodeBlock.cpp (modified) (3 diffs)
• bytecode/CodeBlock.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-10-10  Andreas Kling  <akling@apple.com>
+
+        Reduce pointless malloc traffic in CodeBlock construction.
+        <https://webkit.org/b/149999>
+
+        Reviewed by Antti Koivisto.
+
+        Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
+        instead of first creating a Vector<Instruction> and then creating a RefCountedArray
+        from that. None of the Vector functionality is needed here anyway.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::finishCreation):
+        (JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
+        * bytecode/CodeBlock.h:
+
 2015-10-10  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -1887 +1887 @@
     HashSet<JSModuleEnvironment*> stronglyReferencedModuleEnvironments;
 
-    Vector<Instruction, 0, UnsafeVectorOverflow> instructions(instructionCount);
+    RefCountedArray<Instruction> instructions(instructionCount);
 
     for (unsigned i = 0; !instructionReader.atEnd(); ) {
@@ -2184 +2184 @@
         insertBasicBlockBoundariesForControlFlowProfiler(instructions);
 
-    m_instructions = WTF::RefCountedArray<Instruction>(instructions);
+    m_instructions = WTF::move(instructions);
 
     // Set optimization thresholds only after m_instructions is initialized, since these
@@ -4081 +4081 @@
 #endif
 
-void CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler(Vector<Instruction, 0, UnsafeVectorOverflow>& instructions)
+void CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler(RefCountedArray<Instruction>& instructions)
 {
     const Vector<size_t>& bytecodeOffsets = unlinkedCodeBlock()->opProfileControlFlowBytecodeOffsets();

trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

@@ -1001 +1001 @@
     }
 
-    void insertBasicBlockBoundariesForControlFlowProfiler(Vector<Instruction, 0, UnsafeVectorOverflow>&);
+    void insertBasicBlockBoundariesForControlFlowProfiler(RefCountedArray<Instruction>&);
 
     WriteBarrier<UnlinkedCodeBlock> m_unlinkedCode;