Changeset 190856 in webkit

Timestamp:

Oct 12, 2015 10:01:05 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Use --version-script only on Linux
​https://bugs.webkit.org/show_bug.cgi?id=144555

Patch by Philip Chimento <​philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.

• Source/cmake/OptionsGTK.cmake: Don't add --version-script

option on Darwin (whose linker doesn't support it.)

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsGTK.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2015-10-12  Philip Chimento  <philip.chimento@gmail.com>
+
+        [GTK] Use --version-script only on Linux
+        https://bugs.webkit.org/show_bug.cgi?id=144555
+
+        Reviewed by Philippe Normand.
+
+        * Source/cmake/OptionsGTK.cmake: Don't add --version-script
+        option on Darwin (whose linker doesn't support it.)
+
 2015-10-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 

trunk/Source/cmake/OptionsGTK.cmake

@@ -105 +105 @@
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC OFF)
     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE OFF)
-    set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/gtksymbols.filter")
+    if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
+        set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/gtksymbols.filter")
+    endif ()
 endif ()