Changeset 190881 in webkit

Timestamp:

Oct 12, 2015 12:36:03 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

VisitedValueCount GC Counter misses parallel SlotVisitors
​https://bugs.webkit.org/show_bug.cgi?id=149980

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-12
Reviewed by Geoffrey Garen.

• heap/Heap.cpp:

(JSC::Heap::updateObjectCounts):
Include threaded slot visitor's object counts in the debugging value.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/Heap.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-10-12  Joseph Pecoraro  <pecoraro@apple.com>
+
+        VisitedValueCount GC Counter misses parallel SlotVisitors
+        https://bugs.webkit.org/show_bug.cgi?id=149980
+
+        Reviewed by Geoffrey Garen.
+
+        * heap/Heap.cpp:
+        (JSC::Heap::updateObjectCounts):
+        Include threaded slot visitor's object counts in the debugging value.
+
 2015-10-12  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -852 +852 @@
 void Heap::updateObjectCounts(double gcStartTime)
 {
-    GCCOUNTER(VisitedValueCount, m_slotVisitor.visitCount());
+    GCCOUNTER(VisitedValueCount, m_slotVisitor.visitCount() + threadVisitCount());
 
     if (Options::logGC() == GCLogging::Verbose) {