Changeset 190895 in webkit


Ignore:
Timestamp:
Oct 12, 2015 3:40:36 PM (8 years ago)
Author:
mmaxfield@apple.com
Message:

[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
https://bugs.webkit.org/show_bug.cgi?id=150051

Reviewed by Simon Fraser.

There are no typesetting features which aren't kerning nor ligatures.

No new tests because there is no behavior difference.

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::codePath):

  • platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::supportsTypesettingFeatures): Deleted.

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r190894 r190895  
     12015-10-12  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
     4        https://bugs.webkit.org/show_bug.cgi?id=150051
     5
     6        Reviewed by Simon Fraser.
     7
     8        There are no typesetting features which aren't kerning nor ligatures.
     9
     10        No new tests because there is no behavior difference.
     11
     12        * platform/graphics/FontCascade.cpp:
     13        (WebCore::FontCascade::codePath):
     14        * platform/graphics/WidthIterator.h:
     15        (WebCore::WidthIterator::supportsTypesettingFeatures): Deleted.
     16
    1172015-10-12  Simon Fraser  <simon.fraser@apple.com>
    218
  • trunk/Source/WebCore/platform/graphics/FontCascade.cpp

    r190242 r190895  
    604604    if (m_fontDescription.featureSettings().size() > 0 || !m_fontDescription.variantSettings().isAllNormal())
    605605        return Complex;
    606    
    607     if (run.length() > 1 && !WidthIterator::supportsTypesettingFeatures(*this))
     606
     607#if !PLATFORM(COCOA)
     608    if (run.length() > 1 && typesettingFeatures())
    608609        return Complex;
     610#endif
    609611
    610612    if (!run.characterScanForCodePath())
  • trunk/Source/WebCore/platform/graphics/WidthIterator.h

    r189557 r190895  
    6262#endif
    6363
    64     static bool supportsTypesettingFeatures(const FontCascade& font)
    65     {
    66 #if PLATFORM(COCOA)
    67         return !(font.typesettingFeatures() & ~(Kerning | Ligatures));
    68 #else
    69         return !font.typesettingFeatures();
    70 #endif
    71     }
    72 
    7364    const FontCascade* m_font;
    7465
Note: See TracChangeset for help on using the changeset viewer.