Changeset 190920 in webkit

Timestamp:

Oct 12, 2015 7:11:44 PM (9 years ago)

Author:

jonlee@apple.com

Message:

Add canvas line path tests
​https://bugs.webkit.org/show_bug.cgi?id=150076
<rdar://problem/23082285>

Reviewed by Dean Jackson.

• Animometer/runner/resources/tests.js: Add new line path tests, with different

line joins.

• Animometer/tests/simple/resources/simple-canvas-paths.js:

(CanvasLinePathStage): The stage is the same as the SimpleCanvasPathStrokeStage
but sets the lineJoin on the context.
(CanvasPathBenchmark.prototype.createStage): Add the tests.

Location:

trunk/PerformanceTests

Files:

• Animometer/runner/resources/tests.js (modified) (1 diff)
• Animometer/tests/simple/resources/simple-canvas-paths.js (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/PerformanceTests/Animometer/runner/resources/tests.js

@@ -152 +152 @@
         },
         {
+            url: "simple/simple-canvas-paths.html?pathType=linePath&lineJoin=bevel",
+            name: "Canvas line path, bevel join"
+        },
+        {
+            url: "simple/simple-canvas-paths.html?pathType=linePath&lineJoin=round",
+            name: "Canvas line path, round join"
+        },
+        {
+            url: "simple/simple-canvas-paths.html?pathType=linePath&lineJoin=miter",
+            name: "Canvas line path, miter join"
+        },
+        {
             url: "simple/simple-canvas-paths.html?pathType=quadratic",
             name: "Canvas quadratic segments"

trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js

@@ -213 +213 @@
 CanvasLineSegmentStage.prototype = Object.create(SimpleCanvasStage.prototype);
 CanvasLineSegmentStage.prototype.constructor = CanvasLineSegmentStage;
+
+function CanvasLinePathStage(element, options)
+{
+    SimpleCanvasPathStrokeStage.call(this, element, options, CanvasLinePoint);
+    this.context.lineJoin = options["lineJoin"] || "bevel";
+}
+CanvasLinePathStage.prototype = Object.create(SimpleCanvasPathStrokeStage.prototype);
+CanvasLinePathStage.prototype.constructor = CanvasLinePathStage;
 
 // === BENCHMARK ===
@@ -226 +234 @@
     case "line":
         return new CanvasLineSegmentStage(element, this._options);
+    case "linePath": {
+        if ("lineJoin" in this._options)
+            return new CanvasLinePathStage(element, this._options);
+        break;
+    }
     case "quadratic":
         return new SimpleCanvasStage(element, this._options, CanvasQuadraticSegment);

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2015-10-12  Jon Lee  <jonlee@apple.com>
+
+        Add canvas line path tests
+        https://bugs.webkit.org/show_bug.cgi?id=150076
+        <rdar://problem/23082285>
+
+        Reviewed by Dean Jackson.
+
+        * Animometer/runner/resources/tests.js: Add new line path tests, with different
+        line joins.
+        * Animometer/tests/simple/resources/simple-canvas-paths.js:
+        (CanvasLinePathStage): The stage is the same as the SimpleCanvasPathStrokeStage
+        but sets the lineJoin on the context.
+        (CanvasPathBenchmark.prototype.createStage): Add the tests.
+
 2015-10-12  Jon Lee  <jonlee@apple.com>